L2JMobius

Wolf Waker Brave Spear - Momentum Power logic implementation

michaldoroz7 · 4 · 70

Online michaldoroz7

  • Vassal
  • *
    • Posts: 5
Hey.

I've implemented logic for adding 20% more damage for charging skills when Brave Spear - Momentum Power is ON, also added this buff to GK and Duelist which needed a little script because of not typical process -> 110 lvl gives skill Momentum Power of Valor which replace old Brave Spear with the new one. Right now it's working but maybe there is a better handle for it or create more generic code to use it in the future if similar skills will appear.

Patches: https://drive.google.com/file/d/1PiTM8d9f5zPRxSEIQniPW_k7mekIShbo/view?usp=sharing


Online Mobius

  • Distinguished King
  • *****
    • Posts: 19654
I really think on somewhat replace MomentumPowerUpgrade.java with some new skilltree parameter.

Isn't the existing skilltree removeSkill parameter enough?
It can be used with multiple skills.


Online michaldoroz7

  • Vassal
  • *
    • Posts: 5
I don’t have access right now to code but the idea I’m thinking about right now is to add generic parameter to skills tree XML like <replaceskill> which will handle cases like this.


Online Mobius

  • Distinguished King
  • *****
    • Posts: 19654