Superion Giats enchant scroll problem.

[Hitokiri]

Good day all. The problem is that while enchatnting with Giants Enchant Scroll you can`t add any stones as an support enchant item.  But minimum Giant Enchant Stone should work with this scrolls. So i went to:
C:\Eclipse\workspace\L2J_Mobius\L2J_Mobius_12.3_Superion\java\org\l2jmobius\gameserver\model\item\enchant\EnchantScroll.java

And found this

Code: [Select]

public EnchantScroll(StatSet set)
    {
        super(set);
        _scrollGroupId = set.getInt("scrollGroupId", 0);
       
        final ItemType type = getItem().getItemType();
        _isWeapon = (type == EtcItemType.ENCHT_ATTR_ANCIENT_CRYSTAL_ENCHANT_WP) || (type == EtcItemType.BLESS_ENCHT_WP) || (type == EtcItemType.ENCHT_WP) || (type == EtcItemType.GIANT_ENCHT_WP);
        _isBlessed = (type == EtcItemType.BLESS_ENCHT_AM) || (type == EtcItemType.BLESS_ENCHT_WP) || (type == EtcItemType.BLESSED_ENCHT_ATTR_INC_PROP_ENCHT_WP) || (type == EtcItemType.BLESSED_ENCHT_ATTR_INC_PROP_ENCHT_AM) || (type == EtcItemType.BLESSED_GIANT_ENCHT_ATTR_INC_PROP_ENCHT_AM) || (type == EtcItemType.BLESSED_GIANT_ENCHT_ATTR_INC_PROP_ENCHT_WP);
        _isBlessedDown = (type == EtcItemType.BLESS_ENCHT_AM_DOWN);
        _isSafe = (type == EtcItemType.ENCHT_ATTR_ANCIENT_CRYSTAL_ENCHANT_AM) || (type == EtcItemType.ENCHT_ATTR_ANCIENT_CRYSTAL_ENCHANT_WP) || (type == EtcItemType.ENCHT_ATTR_CRYSTAL_ENCHANT_AM) || (type == EtcItemType.ENCHT_ATTR_CRYSTAL_ENCHANT_WP);
        _isGiant = (type == EtcItemType.GIANT_ENCHT_AM) || (type == EtcItemType.GIANT_ENCHT_WP);
Added to

Code: [Select]

_isGiant = (type == EtcItemType.GIANT_ENCHT_AM) || (type == EtcItemType.GIANT_ENCHT_WP)
That

Code: [Select]

_isGiant = (type == EtcItemType.GIANT_ENCHT_AM) || (type == EtcItemType.GIANT_ENCHT_WP) || (type == EtcItemType.GIANT_ENCHT_ATTR_INC_PROP_ENCHT_AM) || (type == EtcItemType.GIANT_ENCHT_ATTR_INC_PROP_ENCHT_WP) || (type == EtcItemType.BLESSED_GIANT_ENCHT_ATTR_INC_PROP_ENCHT_AM) || (type == EtcItemType.BLESSED_GIANT_ENCHT_ATTR_INC_PROP_ENCHT_WP);
But the server keep telling Inappropriate enchant conditions while adding stone, the scroll itself works.



Is there any other direction where i can edit this Giant Enchant Scroll mechanics to allow them to use Giant Enchant Stones? Or i am doing something wrong? I would be thankful for any help, thank you.

[Mobius]

Added to

Code: [Select]

_isGiant = (type == EtcItemType.GIANT_ENCHT_AM) || (type == EtcItemType.GIANT_ENCHT_WP)
That

Code: [Select]

_isGiant = (type == EtcItemType.GIANT_ENCHT_AM) || (type == EtcItemType.GIANT_ENCHT_WP) || (type == EtcItemType.GIANT_ENCHT_ATTR_INC_PROP_ENCHT_AM) || (type == EtcItemType.GIANT_ENCHT_ATTR_INC_PROP_ENCHT_WP) || (type == EtcItemType.BLESSED_GIANT_ENCHT_ATTR_INC_PROP_ENCHT_AM) || (type == EtcItemType.BLESSED_GIANT_ENCHT_ATTR_INC_PROP_ENCHT_WP);

This seems logical.

[CostyKiller]

I just tested on wolf branch and seems fine without any changes, only thing you need to take care of, is to use the same type of support stone as the scroll you use (eg: giant scroll - giant stone).
Also I noticed that if you try to use wrong support stone, it may send you the same message (Inappropriate enchant conditions.) until you reopen the enchant window.

[Mobius]

Forgot to mention that there is a distinction on support items and enchant scrolls.