High Five Enchant Heavy Armor (S Grade) - MP Recovery Bonus never applied

[Noza]

Affected file: game/data/stats/skills/08400-08499.xml
Lines: 1093-1114

Problem:
The MP Recovery Bonus from skill 8461 - Enchant Heavy Armor (S Grade) was never being applied due to an impossible condition. The original XML required the player to be resting (sitting) AND standing at the same time, which are mutually exclusive states, so the regMp bonus was effectively dead code.

Diff:

Code: (diff) [Select]

--- a/game/data/stats/skills/08400-08499.xml
+++ b/game/data/stats/skills/08400-08499.xml
@@ -1093,22 +1093,16 @@
<skill id="8461" levels="1" name="Enchant Heavy Armor (S Grade)">
<!-- P. Def and MP Recovery Bonus increase when a set item is enchanted. -->
<set name="icon" val="icon.skill0231" />
<set name="operateType" val="P" />
<set name="targetType" val="SELF" />
<set name="magicLevel" val="1" />
<effects>
<effect name="Buff">
<add stat="pDef" val="70">
<using kind="HEAVY" />
</add>
- <add stat="regMp" val="32">
- <and>
- <player resting="true" />
- <or>
- <player standing="true" />
- </or>
- </and>
- </add>
+ <add stat="regMp" val="32" />
</effect>
</effects>
</skill>
[\code]
Fix:
Removed the impossible condition entirely. The +32 regMp bonus now applies unconditionally, matching the skill's intended description: "P. Def and MP Recovery Bonus increase when a set item is enchanted."

[Noza]

Same bug confirmed across all Heavy Armor set grades in 03600-03699.xml (D, C, B, A and S grade).
All affected skills had the same impossible resting+standing condition on the regMp bonus, meaning
the MP Recovery bonus has never worked for any Heavy Armor set. Fixed all grades at once.

Code: (diff) [Select]

--- a/03600-03699.xml
+++ b/03600-03699.xml
@@ -301,14 +301,7 @@
  <add stat="pDef" val="25">
  <using kind="HEAVY" />
  </add>
- <add stat="regMp" val="1.518">
- <and>
- <player resting="true" />
- <or>
- <player standing="true" />
- </or>
- </and>
- </add>
+ <add stat="regMp" val="1.518" />
  </effect>
  </effects>
  </skill>
@@ -355,14 +348,7 @@
  <add stat="pDef" val="38">
  <using kind="HEAVY" />
  </add>
- <add stat="regMp" val="2.019">
- <and>
- <player resting="true" />
- <or>
- <player standing="true" />
- </or>
- </and>
- </add>
+ <add stat="regMp" val="2.019" />
  </effect>
  </effects>
  </skill>
@@ -409,14 +395,7 @@
  <add stat="pDef" val="44">
  <using kind="HEAVY" />
  </add>
- <add stat="regMp" val="2.25">
- <and>
- <player resting="true" />
- <or>
- <player standing="true" />
- </or>
- </and>
- </add>
+ <add stat="regMp" val="2.25" />
  </effect>
  </effects>
  </skill>
@@ -463,14 +442,7 @@
  <add stat="pDef" val="50">
  <using kind="HEAVY" />
  </add>
- <add stat="regMp" val="2.43">
- <and>
- <player resting="true" />
- <or>
- <player standing="true" />
- </or>
- </and>
- </add>
+ <add stat="regMp" val="2.43" />
  </effect>
  </effects>
  </skill>
@@ -517,14 +489,7 @@
  <add stat="pDef" val="59">
  <using kind="HEAVY" />
  </add>
- <add stat="regMp" val="2.823">
- <and>
- <player resting="true" />
- <or>
- <player standing="true" />
- </or>
- </and>
- </add>
+ <add stat="regMp" val="2.823" />
  </effect>
  </effects>
  </skill>
[code]

[Mobius]

Committed with https://gitlab.com/MobiusDevelopment/L2J_Mobius/-/commit/55e06071dd0eaadeb922a65c33f0fd45087eab2e
Thanks