L2JMobius

Interlude Incorrect npcID for summoning spells

quasilyte · 1 · 208

Offline quasilyte

  • Heir
  • **
    • Posts: 15
Hi. I just started experimenting with https://gitlab.com/MobiusDevelopment/L2J_Mobius
I would normally create a "github issue" (gitlab in this case), but it looks like this repository turned them off, so I will try posting it here

First of all, thank you for this project. ^^
Now to the point

I noticed that some spells have invalid npcid lists. For example, summon shadow and summon silhouette for the first few levels of skill. Take a look at the level 2 of the spell, it summons npc with id 14528

https://gitlab.com/MobiusDevelopment/L2J_Mobius/-/blob/master/L2J_Mobius_CT_0_Interlude/dist/game/data/stats/skills/01200-01299.xml?ref_type=heads#L1620
https://gitlab.com/MobiusDevelopment/L2J_Mobius/-/blob/master/L2J_Mobius_CT_0_Interlude/dist/game/data/stats/npcs/14500-14599.xml?ref_type=heads#L811

Which is a level 37 (!) summon for a level 25 mage. It should be summon level 27 instead. Because of it, leveling up the skill leads to weird results like getting ~lvl52 summon at level 35 and then getting a weaker summon afterwards. I am not sure how many other summoning spells are affected, but these two (shadow and silhouette) were the ones I verified.

Shadow levels advance like this:
14479 22lvl (wizard lvl20)
14480 32lvl (wizard lvl25)
14481 42lvl (wizard lvl30)
14482 50lvl (wizard lvl35)
14483 58lvl (summoner lvl40)
14484 27lvl
14485 37lvl
14486 46lvl
14487 54lvl
14488 60lvl
14489 62lvl

And then it looks like they're becoming correct with a +2 level scaling per level

I could theoretically send a pull request (or merge request, in terms of gitlab) if it's encouraged by this project (but I get the feeling that it's not, since the dev version is only for subscribers while the repository referenced above is some unknown stale state of it).

Were these files auto-generated somehow? It looks somewhat unlikely that they were created by hand...