Instance - ChamberOfProphecies Bugged on REV - 2015 (Fix)

[estebanizca93]

USE BETTER FIX BY gigilo1968!!

Hi, I repor BUG at ChamberOfProphecies, when you have been teleported to ChamberOfProphecies while you doing Quest Q10753_WindsOfFateChoices, the NPC Kain van Halter isnt correct Instance.

I discover thar bug is why NPC Kain van Halter ID: 33979 have two instances, one in ChamberOfProphecies and other in FortressOfTheDead.

To solve this problem, I create a custom NPC with another ID but the same model and modified the CamberOfProphecies.java.

My fix is:

Add in game/data/stats/npcs/custom/custom.xml

Code: [Select]

<npc id="339799" displayId="33979" level="85" type="L2Npc" name="Kain van Halter" title="" usingServerSideName="true" usingServerSideTitle="true">
<!-- AUTO GENERATED NPC TODO: FIX IT -->
<race>HUMAN</race>
<sex>FEMALE</sex>
<stats str="88" int="79" dex="55" wit="78" con="82" men="78">
<vitals hp="278980" hpRegen="9.5" mp="18468" mpRegen="3.3" />
<speed>
<walk ground="64" />
<run ground="190" />
</speed>
<attack physical="1189.0459514498" magical="811.85773400546" critical="4" attackSpeed="253" range="40" />
<defence physical="362.06896551724" magical="264.78509919958" />
</stats>
<status attackable="false" />
<skill_list>
<skill id="4416" level="14" /> <!-- Humans -->
<skill id="4045" level="1" /> <!-- Full Magic Attack Resistance -->
</skill_list>
<collision>
<radius normal="9" />
<height normal="20" />
</collision>
</npc>

Modified in game/data/instances/ChamberOfProphecies.xml

Code: [Select]

...
<spawnlist>
<group name="q10753_16_instance_halter_1" spawnByDefault="true">
<npc id="339799" x="-88424" y="186904" z="-10476" heading="49151" respawnTime="60sec" /> <!-- Kain van Halter -->
...

Modified in game\data\scripts\instances\ChamberOfProphecies\ChamberOfProphecies.java

Line 48 --    private static final int KAIN_VAN_HALTER = 339799;
Line 101 --  case "339799-01.html":
Line 143 -- htmltext = "339799-01.html";
Line 146 -- htmltext = "339799-02.html";
Line 414 -- htmltext = "339799.html";

Rename in game\data\scripts\instances\ChamberOfProphecies

33979.html --> 339799.html
33979-1.html --> 339799-1.html
33979-2.html --> 339799-2.html

[gigilo1968]

Tray this

http://pastebin.com/VD4JhKrz

[estebanizca93]

I have tried you fix and it works perfectly. Your fix is much more direct and there isn't need to modify or create anything so I think it is much better.

Thank you and I hope you keep it in mind for the next review.

[estebanizca93]

Hi, after I change and Fix with your code, I sow this error at console of gameserver.

I don't know if this problem is for this fix or error is for another thing.

Thanks.

[gigilo1968]

Delete this quest. or need modification in LetterQuest.java

Code: [Select]

        /**
* Sets if quest is All characters or not.
* @param val {@code false} means {@code Race.NONE}, {@code true} for all races
*/
public final void setIsAllRaceQuest(boolean val)
{
if (val)
{
addCondNotRace(Race.NONE, "");
_startMessage = NpcStringId.THIS_IS_THIS_IS_A_GREAT_ACHIEVEMENT_THAT_IS_WORTHY_OF_THE_TRUE_HEROES_OF_LEGEND;
}
else
{
return;
}
}

and in quest add

Code: [Select]

        public Q10712_TheMinstrelsSongPart1()
{
super(10712);
addTalkId(LIBERATTO);
setIsAllRaceQuest(true);  <---------------- THIS CONDITION
setLevel(MIN_LEVEL, MAX_LEVEL);
setStartLocation(SOE_TALKING_ISLAND, TELEPORT_LOC);
registerQuestItems(SOE_TALKING_ISLAND);
}


[Mobius]

This condition check is only for this quest?

[gigilo1968]

For quest's

10712   The Minstrel's Song, Part 1
10717   The Minstrel's Song, Part 2
10720   The Minstrel's Song, Part 3
10723   The Minstrel's Song, Part 4
10726   The Minstrel's Song, Part 5
10731   The Minstrel's Song, Part 6

[Mobius]

Better to make a setStartMessage(NpcStringId) to set _startMessage.
I will make it when I have some time.

We got these quests?

[gigilo1968]

Nope html 

[Mobius]

Fixed with revision 2017.