C4 Adjustments to starter villages repeatable quests based on turning in items

[altronrain]

Present state: Most part of starter quests that based on turning in items have addtitional adena reward for items count 10+. But not all the quests.

The goal of this contribution is to:

• Make all the quests mentioned to include addtitional reward;
• Make this behaviour configurable via config setting (cause it seems a legal mechanic for C4, but not all the people are fond for running back and forth every 10 mobs + it's customisable way);
• Adjust some quests rewards in the process according to sources used;
Quests involved:

• Q257_TheGuardIsBusy: Adjust reward formula. Amulet - 5adena, fang - 10adena, neckle - 15adena. Additional 1000 adena reward if item count 10+ already applies
• Q260_HuntTheOrcs: Should have additional 1000 adena reward if item count 10+
• Q263_OrcSubjugation: Should have additional 1000 adena reward if item count 10+
• Q265_ChainsOfSlavery: Additional 500 adena reward if item count 10+ already applies
• Q267_WrathOfVerdure: Should have additional 600 adena reward if item count 10+
• Q273_InvadersOfTheHolyLand: Reward could be as it is now 3a/10a, but according to low chances for Reds & low reward for Blacks I prefer 5a/50a adjustment. Additional 1500/1800 adena reward if item count 10+ already applies
• Q292_BrigandsSweep: Additional 500 adena reward if item count 10+ already applies
• Q293_TheHiddenVeins: Additional 2000 adena reward if item count 10+ already applies. Adjusted adena reward (10a/1000a instead 5a/500a)
• Q296_TarantulasSpiderSilk: Additional 2000 adena reward if item count 10+ already applies. Adjusted adena reward formula (20a instead of 30a per item)
• Q306_CrystalsOfFireAndIce: Adjust reward formula. Each crystal should award 60a (not 30a). Additional 5000 adena reward if item count 10+ already applies
• Q316_DestroyPlagueCarriers: Additional 5000 adena reward if item count 10+ already applies. Adjusted adena reward per item (60a instead of 30a).
• Q317_CatchTheWind: Adjust reward formula. Each crystal should award 30a (not 40a). Additional 2988 adena reward if item count 10+ already applies
• + Q259_RanchersPlea: There also was additional adena reward. Condition added.
[/li]

Sources used:
+ some sources of java servers from the past

• https://l2db.ru/quests/index/0/0/1
• https://base.l2ultra.ru/?part=quests
• https://www.l2scroll.com/2019/09/quests-for-levels-1-21-start-villages.html
• https://l2vika.ru/kvesty.html
• Additionally checked most of the quests on ElmoreLab C4 (https://elmorelab.com/ru/index.html) (not advertrising) as an example. They have additional rewards.

I beleive it works after series of tests on my server instance.

N.B.: diff patch was made on top of https://l2jmobius.org/forum/index.php?topic=8620.0 changes.
Pastebin link: https://pastebin.com/A12sPfeX

[altronrain]

Edited initial post. Replaced pastebin link.
Make changes in adena rewards for Q293_TheHiddenVeins, Q296_TarantulasSpiderSilk, Q316_DestroyPlagueCarriers after better looking at sources (+ new ones I got).
Plus added Q259_RanchersPlea where additional adena reward also took place.

[Mobius]

Patch cannot be applied, uses spaces instead of tabs. Also file names include date.
It is not compatible with what we use in Eclipse.

[altronrain]

Oops, sorry for that. I'm skilled at using Eclipse. Used WinMerge utility to create diff patches based on files differences. Is there an alternative way for Win OS?
And that's really a problem of some kind cause for now I could only compare my tainted version with all the fixes with fresh code from repo. Not separated on topicks started.

[nasseka]

I use winmerge too. Remove backup when u merge ?

[Mobius]

Oops, sorry for that. I'm skilled at using Eclipse. Used WinMerge utility to create diff patches based on files differences. Is there an alternative way for Win OS?
And that's really a problem of some kind cause for now I could only compare my tainted version with all the fixes with fresh code from repo. Not separated on topicks started.

https://l2jmobius.org/forum/index.php?topic=896

[altronrain]

well. Made it according to instructions.
But the problem stays the same. It's all in 1 huge diff. Should I rip off needed changes only (manually)?

https://pastebin.com/tge8irq3

Or this one:
Left only this and https://l2jmobius.org/forum/index.php?topic=8620.0 topics changes (cause they are mostly related)

https://pastebin.com/NaVFkvrq

[Mobius]

I committed https://l2jmobius.org/forum/index.php?topic=8620
Now I can't apply either patch.

[altronrain]

Got it. I guess I could use latest source (if I could), I just need to replace related files and create a new diff. I'll try.

[altronrain]

https://pastebin.com/2hnQTPgg

That should do the trick.

[Mobius]

Committed with https://bitbucket.org/MobiusDev/l2j_mobius/commits/af35feb7fc00eb57aca384d1638039a73cb77698
Thanks