L2JMobius

C6 [Skill Sell] Npc

Pirsys · 3 · 6700

Offline Pirsys

  • Knight
  • ***
    • Posts: 67
Hello everyone, I found the code for this ncp on the web, I adapted it and it works 80%, I'm having a problem when the player relogs the learned skill disappears, could you guide me why? Since I added the line that Update the player's status by learning the skills. I leave the code below.


Code: [Select]
* Copyright (C) 2004-2014 L2J DataPack
 *
 * This file is part of L2J DataPack.
 *
 * L2J DataPack is free software: you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation, either version 3 of the License, or
 * (at your option) any later version.
 *
 * L2J DataPack is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
 * General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License
 * along with this program. If not, see <http://www.gnu.org/licenses/>.
 */
package quests.Q689_SkillSeller;

import java.util.ArrayList;
import java.util.List;
import java.util.StringTokenizer;

import org.l2jmobius.gameserver.data.ItemTable;
import org.l2jmobius.gameserver.model.actor.Npc;
import org.l2jmobius.gameserver.model.actor.Player;
import org.l2jmobius.gameserver.model.quest.Quest;
import org.l2jmobius.gameserver.model.quest.QuestState;
import org.l2jmobius.gameserver.model.skill.holders.SkillHolder;
import org.l2jmobius.gameserver.network.serverpackets.SocialAction;

/**
 * @author fissban
 */
public class Q689_SkillSeller extends Quest
{
// Npc
private static final int NPC = 20;
// Cantidad maxima q un user puede aprender de skills.
private static final int MAX_SKILLS_ADD = 5;
// Precio por aprender cada skills....
private static final int ITEMD_ID = 57; // Adena
private static final int ITEM_COUNT = 1000; // Cantidad
// Skills a regalar (SkillId - SkillLvl)
private static final List<SkillHolder> SKILLS = new ArrayList<>();
{
SKILLS.add(new SkillHolder(1085, 113));// Acumen
SKILLS.add(new SkillHolder(1035, 104));// Mental Shield
SKILLS.add(new SkillHolder(1036, 112));// Magic Barrier
SKILLS.add(new SkillHolder(1040, 113));// Shield
SKILLS.add(new SkillHolder(1045, 116));// Blessed Body
SKILLS.add(new SkillHolder(1048, 116));// Blessed Soul
SKILLS.add(new SkillHolder(1059, 103));// Empower
SKILLS.add(new SkillHolder(1062, 2));// Berserker Spirit
SKILLS.add(new SkillHolder(1068, 3));// Might
SKILLS.add(new SkillHolder(1077, 3));// Focus
SKILLS.add(new SkillHolder(1078, 6));// Concentration
SKILLS.add(new SkillHolder(1086, 2));// Haste
SKILLS.add(new SkillHolder(1087, 3));// Agility
SKILLS.add(new SkillHolder(1204, 2));// Wind Walk
SKILLS.add(new SkillHolder(1240, 3));// Guidance
SKILLS.add(new SkillHolder(1242, 3));// Death Whisper
SKILLS.add(new SkillHolder(1243, 6));// Bless Shield
SKILLS.add(new SkillHolder(1268, 4));// Vampiric Rage
}

private Q689_SkillSeller()
{
super(-1, Q689_SkillSeller.class.getSimpleName());
addStartNpc(NPC);
addFirstTalkId(NPC);
addTalkId(NPC);
}

@Override
public String onFirstTalk(Npc npc, Player activeChar)
{
return GenerateHtmlIndex(activeChar);
}

@Override
public String onAdvEvent(String event, Npc npc, Player player)
{
if (event.equals("verSkills"))
{
return GenerateHtmlRegalos(player);
}
if (event.startsWith("regalarSkills"))
{
QuestState qs = player.getQuestState(getName());
// Verificamos la cant de skills q ah aprendido el char
if (qs.getInt("skills") >= MAX_SKILLS_ADD)
{
return "maxSkills.htm";
}

StringTokenizer st = new StringTokenizer(event, " ");
st.nextToken(); // regalarSkills

try
{
if (qs.getQuestItemsCount(ITEMD_ID) >= ITEM_COUNT)
{
qs.takeItems(ITEMD_ID, ITEM_COUNT);
player.addSkill(SKILLS.get(Integer.parseInt(st.nextToken())).getSkill(), true);
player.broadcastUserInfo();
player.broadcastPacket(new SocialAction(player.getObjectId(), 3));
player.sendMessage("has aprendio un nuevo skills!"); // se podria cambiar por un html no?
qs.set("skills", qs.getString("skills") + 1); // incrementamos la cant de skills q ah aprendido el char
}
}
catch (Exception e)
{
LOGGER.warning("WTF...tenemos un player q intenta aprender un skill fuera de la lista?");
LOGGER.warning("contactar con fissban por asesoria :P");
}

}
return null;
}

/**
* Generamos el html inicial
* @param player
* @return
*/
private static String GenerateHtmlIndex(Player player)
{
StringBuilder sb = new StringBuilder();
sb.append("<html><body><title>L2jAdmins</title>");
sb.append("<center>");
sb.append("<br>");
sb.append("Bienvenido <font color=\"LEVEL\">" + player.getName() + "</font>");
sb.append("<br>");
sb.append("<center>");
sb.append("Usted podra comprar algunos skills para su char<br>");
sb.append("pero no seran gratuitos..no no no!<br>");
sb.append("por la suma de " + ITEM_COUNT + " de " + ItemTable.getInstance().getTemplate(ITEMD_ID).getName() + "<br>");
sb.append("pasa por nuestra tiendra y ve nuestros skills");
sb.append("<button value=\"Ver Skills\" action=\"bypass -h Quest NpcRegaloSkills verSkills\" width=120 height=30 back=L2UI_CH3.bigbutton2_down fore=L2UI_CH3.bigbutton2></td>");
sb.append("</center>");
sb.append("</body></html>");

return sb.toString();
}

/**
* Generamos los html para cada lista de Skills a regalar
* @param player
* @return
*/
private static String GenerateHtmlRegalos(Player player)
{
StringBuilder sb = new StringBuilder();
sb.append("<html><body><title>L2jAdmins</title>");
sb.append("<center>");
sb.append("<br>");
sb.append("Bienvenido <font color=\"LEVEL\">" + player.getName() + "</font>");
sb.append("<br>");

int cont = 0;

for (SkillHolder skill : SKILLS)
{
if (skill.getSkill() == null)
{
LOGGER.warning("skill null -->> " + cont);
LOGGER.warning("contactar a fissban por este nullPoint");
cont++;
continue;
}
sb.append("<table bgcolor=\"13458B\" width=260 height=36>");
sb.append("<tr>");
sb.append("<td width=32 height=32><img src=\"Icon.skill" + getSkillIcon(skill.getSkillId()) + "\"  width=32 height=32></td>");
sb.append("<td align=center width=196 height=32><button value=\"Aprender " + skill.getSkill().getName() + "\" action=\"bypass -h Quest NpcRegaloSkills regalarSkills " + cont + "\" width=120 height=30 back=L2UI_CH3.bigbutton2_down fore=L2UI_CH3.bigbutton2></td>");
sb.append("<td width=32 height=32><img src=\"Icon.skill" + getSkillIcon(skill.getSkillId()) + "\"  width=32 height=32></td>");
sb.append("</tr>");
sb.append("</table>");
cont++;
}

sb.append("</center>");
sb.append("</body></html>");

return sb.toString();
}

/**
* Generamos el ID de la imagen de un skill a partir de su ID
* @param id
* @return
*/
private static String getSkillIcon(int id)
{
String formato;
if (id == 4)
{
formato = "0004";
}
else if ((id > 9) && (id < 100))
{
formato = "00" + id;
}
else if ((id > 99) && (id < 1000))
{
formato = "0" + id;
}
else if (id == 1517)
{
formato = "1536";
}
else if (id == 1518)
{
formato = "1537";
}
else if (id == 1547)
{
formato = "0065";
}
else if (id == 2076)
{
formato = "0195";
}
else if ((id > 4550) && (id < 4555))
{
formato = "5739";
}
else if ((id > 4698) && (id < 4701))
{
formato = "1331";
}
else if ((id > 4701) && (id < 4704))
{
formato = "1332";
}
else if (id == 6049)
{
formato = "0094";
}
else
{
formato = String.valueOf(id);
}
return formato;
}

public static void main(String[] args)
{
new Q689_SkillSeller();
}
}


Offline Pirsys

  • Knight
  • ***
    • Posts: 67
I am having problems, since some players can learn the 3 skills and others only 2, if someone can help me please. So the code remains 100% I will thank you.

Code: [Select]
/**
* Copyright (C) 2004-2014 L2J DataPack
*
* This file is part of L2J DataPack.
*
* L2J DataPack is free software: you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation, either version 3 of the License, or
* (at your option) any later version.
*
* L2J DataPack is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
* General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*/

package quests.Q689_SkillSeller;

import java.util.ArrayList;
import java.util.List;
import java.util.StringTokenizer;

import org.l2jmobius.gameserver.model.actor.Npc;
import org.l2jmobius.gameserver.model.actor.Player;
import org.l2jmobius.gameserver.model.quest.Quest;
import org.l2jmobius.gameserver.model.quest.QuestState;
import org.l2jmobius.gameserver.model.skill.holders.SkillHolder;
import org.l2jmobius.gameserver.network.serverpackets.SocialAction;

/**
 * @author fissban
 */
public class Q689_SkillSeller extends Quest
{
// Npc
private static final int NPC = 20;
// Cantidad maxima q un user puede aprender de skills.
private static final int MAX_SKILLS_ADD = 3;
// Precio por aprender cada skills....
private static final int ITEMD_ID = 9209; // Adena
private static final int ITEM_COUNT = 10; // Cantidad
// Skills a regalar (SkillId - SkillLvl)
private static final List<SkillHolder> SKILLS = new ArrayList<>();
{
SKILLS.add(new SkillHolder(365, 1));// Acumen
SKILLS.add(new SkillHolder(364, 1));// Mental Shield
SKILLS.add(new SkillHolder(349, 1));// Magic Barrier
SKILLS.add(new SkillHolder(305, 1));// Empower
SKILLS.add(new SkillHolder(1355, 1));// Focus
SKILLS.add(new SkillHolder(1356, 1));// Concentration
SKILLS.add(new SkillHolder(1357, 1));// Concentration
SKILLS.add(new SkillHolder(1413, 1));// Haste
SKILLS.add(new SkillHolder(1363, 1));// Agility
SKILLS.add(new SkillHolder(1388, 3));// Wind Walk
SKILLS.add(new SkillHolder(1389, 3));// Guidance
SKILLS.add(new SkillHolder(1416, 1));// Death Whisper
SKILLS.add(new SkillHolder(4699, 13));// Shield
SKILLS.add(new SkillHolder(4700, 13));// Blessed Body
SKILLS.add(new SkillHolder(4703, 13));// Blessed Soul

}

public Q689_SkillSeller()
{
super(689, "Skill Seller!");
addStartNpc(NPC);
addFirstTalkId(NPC);
addTalkId(NPC);
}

@Override
public String onFirstTalk(Npc npc, Player activeChar)
{
return GenerateHtmlIndex(activeChar);
}

@Override
public String onAdvEvent(String event, Npc npc, Player player)
{
if (event.equals("verSkills"))
{
return GenerateHtmlRegalos(player);
}
if (event.startsWith("regalarSkills"))
{
QuestState qs = player.getQuestState(getName());
// Verificamos la cant de skills q ah aprendido el char

System.out.println("a" + qs.getInt("skills"));

if (qs.getInt("skills") >= MAX_SKILLS_ADD)
{
return "maxSkills.htm";
}

StringTokenizer st = new StringTokenizer(event, " ");
st.nextToken(); // regalarSkills

try
{
if (qs.getQuestItemsCount(ITEMD_ID) >= ITEM_COUNT)
{
qs.takeItems(ITEMD_ID, ITEM_COUNT);
player.broadcastPacket(new SocialAction(player.getObjectId(), 3));
qs.set("skills", qs.getString("skills") + 1); // incrementamos la cant de skills q ah aprendido el char
System.out.println("b" + qs.getString("skills") + 1);
player.sendSkillList();
player.addSkill(SKILLS.get(Integer.parseInt(st.nextToken())).getSkill(), true);
player.broadcastUserInfo();
}

else
{
return "noitem.htm";
}
}
catch (Exception e)
{
LOGGER.warning("WTF...tenemos un player q intenta aprender un skill fuera de la lista?");
LOGGER.warning("contactar con fissban por asesoria :P");
}

}
return null;
}

/**
* Generamos el html inicial
* @param player
* @return
*/
private static String GenerateHtmlIndex(Player player)
{

return "verskill.htm";
}

/**
* Generamos los html para cada lista de Skills a regalar
* @param player
* @return
*/
private static String GenerateHtmlRegalos(Player player)
{

StringBuilder sb = new StringBuilder();
sb.append("<html><body><title>Lineage II Freedom - Private Server</title>");
sb.append("<center>");
sb.append("<br>");
sb.append("Bienvenido <font color=\"LEVEL\">" + player.getName() + "</font>");
sb.append("<br>");

int cont = 0;

for (SkillHolder skill : SKILLS)
{
if (skill.getSkill() == null)
{
LOGGER.warning("skill null -->> " + cont);
LOGGER.warning("contactar a fissban por este nullPoint");
cont++;
continue;
}

sb.append("<table bgcolor=\"ae9987\" width=260 height=36>");
sb.append("<tr>");
sb.append("<td width=32 height=32><img src=\"Icon.skill" + getSkillIcon(skill.getSkillId()) + "\"  width=32 height=32></td>");
sb.append("<td align=center width=196 height=32><button value=\"" + skill.getSkill().getName() + "\" action=\"bypass -h Quest Q689_SkillSeller regalarSkills " + cont + "\" width=120 height=30 back=L2UI_CH3.bigbutton2_down fore=L2UI_CH3.bigbutton2></td>");
sb.append("<td width=32 height=32><img src=\"Icon.skill" + getSkillIcon(skill.getSkillId()) + "\"  width=32 height=32></td>");
sb.append("</tr>");
sb.append("</table>");

cont++;

}

sb.append("</center>");
sb.append("</body></html>");

return sb.toString();
}

/**
* Generamos el ID de la imagen de un skill a partir de su ID
* @param id
* @return
*/
private static String getSkillIcon(int id)
{
String formato;
if (id == 4)
{
formato = "0004";
}
else if ((id > 9) && (id < 100))
{
formato = "00" + id;
}
else if ((id > 99) && (id < 1000))
{
formato = "0" + id;
}
else if (id == 1517)
{
formato = "1536";
}
else if (id == 1518)
{
formato = "1537";
}
else if (id == 1547)
{
formato = "0065";
}
else if (id == 2076)
{
formato = "0195";
}
else if ((id > 4550) && (id < 4555))
{
formato = "5739";
}
else if ((id > 4698) && (id < 4701))
{
formato = "1331";
}
else if ((id > 4701) && (id < 4704))
{
formato = "1332";
}
else if (id == 6049)
{
formato = "0094";
}
else
{
formato = String.valueOf(id);
}
return formato;
}

public static void main(String[] args)
{
new Q689_SkillSeller();
}
}


Online Mobius

  • Distinguished King
  • *****
    • Posts: 16055
System.out.println("b" + qs.getString("skills") + 1);
->
System.out.println("b" + qs.getString("skills"));

You already incremented it above.

Code seems ok.