High Five Frintezza Instance Boss Problems

[uchihasv]

Hello i'm try test Frintezza(and Instance zone) and get some problems:
- If someone in party leave your instance will be close in serveral seconds
- If someone dead and return to village - them can't re-enter in Instance
- Instance don't have global cooldown after kill Boss?
- Frintezza not Playing on music Instrument
- Scarlet Van Halisha visually disappear for a second after use "Rush skill" on Player
- And instead of Scarlet Van Halisha can be spawn Invisible/invul monster without name and hp bar in target, but u can attack him



If last problem happen u get this:

Code: [Select]

Exception in thread "pool-3-thread-2" java.util.NoSuchElementException: No value present
at java.base/java.util.Optional.get(Optional.java:143)
at instances.FinalEmperialTomb.FinalEmperialTomb$StatusTask.addAggroToMobs(FinalEmperialTomb.java:1387)
at instances.FinalEmperialTomb.FinalEmperialTomb$StatusTask.run(FinalEmperialTomb.java:1360)
at org.l2jmobius.commons.threads.RunnableWrapper.run(RunnableWrapper.java:35)
at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:539)
at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
at java.base/java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:304)
at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
at java.base/java.lang.Thread.run(Thread.java:833)
Exception in thread "pool-5-thread-2" java.util.NoSuchElementException: No value present
at java.base/java.util.Optional.get(Optional.java:143)
at instances.FinalEmperialTomb.FinalEmperialTomb$StatusTask.addAggroToMobs(FinalEmperialTomb.java:1387)
at instances.FinalEmperialTomb.FinalEmperialTomb$StatusTask.run(FinalEmperialTomb.java:1374)
at org.l2jmobius.commons.threads.RunnableWrapper.run(RunnableWrapper.java:35)
at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:539)
at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
at java.base/java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:304)
at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
at java.base/java.lang.Thread.run(Thread.java:833)
After some minutes get this:

Code: [Select]

Exception in thread "pool-3-thread-2" java.lang.IndexOutOfBoundsException: Index 3 out of bounds for length 3
at java.base/jdk.internal.util.Preconditions.outOfBounds(Preconditions.java:64)
at java.base/jdk.internal.util.Preconditions.outOfBoundsCheckIndex(Preconditions.java:70)
at java.base/jdk.internal.util.Preconditions.checkIndex(Preconditions.java:266)
at java.base/java.util.Objects.checkIndex(Objects.java:359)
at java.base/java.util.ArrayList.get(ArrayList.java:427)
at instances.FinalEmperialTomb.FinalEmperialTomb$IntroTask.run(FinalEmperialTomb.java:1012)
at org.l2jmobius.commons.threads.RunnableWrapper.run(RunnableWrapper.java:35)
at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:539)
at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
at java.base/java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:304)
at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
at java.base/java.lang.Thread.run(Thread.java:833)


[uchihasv]

First Exception problem related to this addAggroToMobs() method:

Code: [Select]

private void addAggroToMobs()
{
PlayerInstance target = _world.getAllowed().stream().findAny().get();
if ((target == null) || (target.getInstanceId() != _world.getInstanceId()) || target.isDead() || target.isFakeDeath())
{
for (PlayerInstance plr : _world.getAllowed())
{
if ((plr != null) && (plr.getInstanceId() == _world.getInstanceId()) && !plr.isDead() && !plr.isFakeDeath())
{
target = plr;
break;
}
target = null;
}
}
for (Npc mob : _world.getParameters().getList("npcList", Npc.class, new ArrayList<>()))
{
mob.setRunning();
if (target != null)
{
((MonsterInstance) mob).addDamageHate(target, 0, 500);
mob.getAI().setIntention(CtrlIntention.AI_INTENTION_ATTACK, target);
}
else
{
mob.getAI().setIntention(CtrlIntention.AI_INTENTION_MOVE_TO, MOVE_TO_CENTER);
}
}
}

For example: when u teleport to first room and destroy Device and after doors in circle open - mobs do not addAgro and not running to center as writed in Method and u get NPE in GS.

PlayerInstance target = _world.getAllowed().stream().findAny().get();
Exception in this line with java.util.NoSuchElementException, but why retrun no elements there if players entered in Instance?

Partial fix this Exception:
https://stackoverflow.com/questions/30686215/avoid-nosuchelementexception-with-stream

[bestover72]

You managed to solve this?

Scarlet Van Halisha visually disappear for a second after use "Rush skill" on Player

Because all rush skills are broken, include Player's.

Is hard replicate, you need 2 accounts on separated monitors, and when you rush with one account and if you look to other monitor where you have other account, you see rush like is blinking.

All skills got <effect name="EnemyCharge" />, have this problem.

Dont know how to fix