Homunculus Fix when changing to dual / main not updateing in party window

[LLiuKe]

Probably not the best option to fix this but it does it's job !


game/data/scripts/handlers/effecthandlers/ClassChange.java

Code: [Select]

/*
 * This file is part of the L2J Mobius project.
 *
 * This program is free software: you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation, either version 3 of the License, or
 * (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
 * General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License
 * along with this program. If not, see <http://www.gnu.org/licenses/>.
 */
package handlers.effecthandlers;

import org.l2jmobius.gameserver.data.xml.SkillData;
import org.l2jmobius.gameserver.enums.SubclassInfoType;
import org.l2jmobius.gameserver.model.StatSet;
import org.l2jmobius.gameserver.model.actor.Creature;
import org.l2jmobius.gameserver.model.actor.instance.PlayerInstance;
import org.l2jmobius.gameserver.model.effects.AbstractEffect;
import org.l2jmobius.gameserver.model.items.instance.ItemInstance;
import org.l2jmobius.gameserver.model.olympiad.OlympiadManager;
import org.l2jmobius.gameserver.model.skills.Skill;
import org.l2jmobius.gameserver.network.SystemMessageId;
import org.l2jmobius.gameserver.network.serverpackets.AcquireSkillList;
import org.l2jmobius.gameserver.network.serverpackets.ExStorageMaxCount;
import org.l2jmobius.gameserver.network.serverpackets.ExSubjobInfo;
import org.l2jmobius.gameserver.network.serverpackets.PartySmallWindowAll;
import org.l2jmobius.gameserver.network.serverpackets.PartySmallWindowDeleteAll;
import org.l2jmobius.gameserver.network.serverpackets.SystemMessage;
import org.l2jmobius.gameserver.network.serverpackets.ability.ExAcquireAPSkillList;

/**
 * @author Sdw
 */
public class ClassChange extends AbstractEffect
{
private final int _index;
private static final int IDENTITY_CRISIS_SKILL_ID = 1570;

public ClassChange(StatSet params)
{
_index = params.getInt("index", 0);
}

@Override
public boolean isInstant()
{
return true;
}

@Override
public void instant(Creature effector, Creature effected, Skill skill, ItemInstance item)
{
if (!effected.isPlayer())
{
return;
}

final PlayerInstance player = effected.getActingPlayer();
if (player.isTransformed() || player.isSubclassLocked() || player.isAffectedBySkill(IDENTITY_CRISIS_SKILL_ID))
{
player.sendMessage("You cannot switch your class right now!");
return;
}

final Skill identityCrisis = SkillData.getInstance().getSkill(IDENTITY_CRISIS_SKILL_ID, 1);
if (identityCrisis != null)
{
identityCrisis.applyEffects(player, player);
}

if (OlympiadManager.getInstance().isRegisteredInComp(player))
{
OlympiadManager.getInstance().unRegisterNoble(player);
}

final int activeClass = player.getClassId().getId();
player.setActiveClass(_index);

final SystemMessage msg = new SystemMessage(SystemMessageId.YOU_HAVE_SUCCESSFULLY_SWITCHED_S1_TO_S2);
msg.addClassId(activeClass);
msg.addClassId(player.getClassId().getId());
player.sendPacket(msg);

player.updateSymbolSealSkills();
player.broadcastUserInfo();

player.sendPacket(new ExStorageMaxCount(player));
player.sendPacket(new AcquireSkillList(player));
player.sendPacket(new ExSubjobInfo(player, SubclassInfoType.CLASS_CHANGED));
player.sendPacket(new ExAcquireAPSkillList(player));
if (player.isInParty())
{
// Delete party window for other party members
player.getParty().broadcastToPartyMembers(player, PartySmallWindowDeleteAll.STATIC_PACKET);
for (PlayerInstance member : player.getParty().getMembers())
{
// And re-add
if (member != player)
{
member.sendPacket(new PartySmallWindowAll(member, player.getParty()));
}
}
}
}
}


[Mobius]

Nice.

[Mobius]

Diff patch.

Code: [Select]

Index: dist/game/data/scripts/handlers/effecthandlers/ClassChange.java
===================================================================
--- dist/game/data/scripts/handlers/effecthandlers/ClassChange.java (revision 9170)
+++ dist/game/data/scripts/handlers/effecthandlers/ClassChange.java (working copy)
@@ -29,6 +29,8 @@
 import org.l2jmobius.gameserver.network.serverpackets.AcquireSkillList;
 import org.l2jmobius.gameserver.network.serverpackets.ExStorageMaxCount;
 import org.l2jmobius.gameserver.network.serverpackets.ExSubjobInfo;
+import org.l2jmobius.gameserver.network.serverpackets.PartySmallWindowAll;
+import org.l2jmobius.gameserver.network.serverpackets.PartySmallWindowDeleteAll;
 import org.l2jmobius.gameserver.network.serverpackets.SystemMessage;
 import org.l2jmobius.gameserver.network.serverpackets.ability.ExAcquireAPSkillList;
 
@@ -91,5 +93,19 @@
  player.sendPacket(new AcquireSkillList(player));
  player.sendPacket(new ExSubjobInfo(player, SubclassInfoType.CLASS_CHANGED));
  player.sendPacket(new ExAcquireAPSkillList(player));
+
+ if (player.isInParty())
+ {
+ // Delete party window for other party members
+ player.getParty().broadcastToPartyMembers(player, PartySmallWindowDeleteAll.STATIC_PACKET);
+ for (PlayerInstance member : player.getParty().getMembers())
+ {
+ // And re-add
+ if (member != player)
+ {
+ member.sendPacket(new PartySmallWindowAll(member, player.getParty()));
+ }
+ }
+ }
  }
 }


[Mobius]

Committed with https://bitbucket.org/MobiusDev/l2j_mobius/commits/7d79a74019de08380788f9d3fa9644d7ea29360f
Thanks