Author Topic: The Kamael Character stuck near stairs with l2j geo  (Read 535 times)

Offline uchihasv

  • Heir
  • **
  • Posts: 47
Character stuck near stairs with l2j geo
« on: February 23, 2021, 06:56:44 PM »
After reverted back to l2j geoengine, characters can stuck near stairs.

Geogrid in screenshot show missing geodata parts when u stuck, but if u check geodata before stuck, then geogrid show u geodata without missing.



This means that part of the geodata can disappear on the fly when you come near any stairs.

Needs to be repaired, as this happens very often in villages with stairs.
DS: uchihasv#1256

Offline uchihasv

  • Heir
  • **
  • Posts: 47
Re: Character stuck near stairs with l2j geo
« Reply #1 on: February 24, 2021, 04:17:34 PM »


This happen after climbing stairs and then it is impossible to go back, the character stuck like an invisible wall.
DS: uchihasv#1256

Online Mobius

  • Administrator
  • Distinguished King
  • *****
  • Posts: 9051
Re: Character stuck near stairs with l2j geo
« Reply #2 on: February 25, 2021, 02:09:07 AM »
The engine used is the same with L2jServer.
Take that in mind to consider that L2jServer ignores this issue.
The problem is still there tho.

A simple solution is to ignore the problem as well, by removing the code that checks if geodata actually exist.
Code: [Select]
Index: java/org/l2jmobius/gameserver/model/actor/Creature.java
===================================================================
--- java/org/l2jmobius/gameserver/model/actor/Creature.java (revision 8319)
+++ java/org/l2jmobius/gameserver/model/actor/Creature.java (working copy)
@@ -3383,6 +3383,7 @@
  final Location destiny = GeoEngine.getInstance().canMoveToTargetLoc(curX, curY, curZ, x, y, z, getInstanceWorld());
  x = destiny.getX();
  y = destiny.getY();
+ z = destiny.getZ();
  dx = x - curX;
  dy = y - curY;
  dz = z - curZ;
@@ -3396,13 +3397,17 @@
  m.geoPath = GeoEnginePathfinding.getInstance().findPath(curX, curY, curZ, originalX, originalY, originalZ, getInstanceWorld());
  if ((m.geoPath == null) || (m.geoPath.size() < 2)) // No path found
  {
+ if ((isPlayer()) || (!isPlayable() && !isMinion() && (Math.abs(z - curZ) > 140)) || (isSummon() && !((Summon) this).getFollowStatus()))
+ {
+ return;
+ }
+
  m.disregardingGeodata = true;
 
- // Mobius: Verify destination. Prevents wall collision issues.
- final Location newDestination = GeoEngine.getInstance().canMoveToTargetLoc(curX, curY, curZ, originalX, originalY, originalZ, getInstanceWorld());
- x = newDestination.getX();
- y = newDestination.getY();
- z = newDestination.getZ();
+ x = originalX;
+ y = originalY;
+ z = originalZ;
+ distance = originalDistance;
  }
  else
  {

Offline uchihasv

  • Heir
  • **
  • Posts: 47
Re: Character stuck near stairs with l2j geo
« Reply #3 on: February 25, 2021, 01:32:54 PM »
Thanks, i'm test geo with this changes.

And how about this commit from l2j for geo:
https://bitbucket.org/l2jserver/l2j-server-game/commits/22678f0ad1e38090cff3807f8ee9f5627f4d0af2
DS: uchihasv#1256

Online Mobius

  • Administrator
  • Distinguished King
  • *****
  • Posts: 9051
Re: Character stuck near stairs with l2j geo
« Reply #4 on: February 25, 2021, 02:19:03 PM »
On our version we do not have intention anyways.

Online Mobius

  • Administrator
  • Distinguished King
  • *****
  • Posts: 9051

Offline uchihasv

  • Heir
  • **
  • Posts: 47
Re: Character stuck near stairs with l2j geo
« Reply #6 on: March 01, 2021, 09:25:22 PM »
Nice work.

I also found another bug with geodata in the new lair of antharas, character can stuck here:


it looks like there is no geodata where bone texture is on the ground or what?
DS: uchihasv#1256

Offline Trance

  • Subscriber
  • Knight
  • ***
  • Posts: 96
Re: Character stuck near stairs with l2j geo
« Reply #7 on: March 04, 2021, 07:39:47 AM »
Nice work.

I also found another bug with geodata in the new lair of antharas, character can stuck here:


it looks like there is no geodata where bone texture is on the ground or what?

Wait a sec. Can you reproduce the bug there or is the geodata simply missing there (without reproducing the bug)?

Offline uchihasv

  • Heir
  • **
  • Posts: 47
Re: Character stuck near stairs with l2j geo
« Reply #8 on: March 04, 2021, 10:00:57 AM »
Wait a sec. Can you reproduce the bug there or is the geodata simply missing there (without reproducing the bug)?
You can check it yourself, I don't know exactly why this bug is happening there.
DS: uchihasv#1256