Goldberg room error when Goldberg have been killed:
jan. 04, 2021 4:07:43 DU. org.l2jmobius.gameserver.model.quest.Quest showError
WARNING: C:\L2J_Mobius2\game\data\scripts\instances\GolbergRoom\GolbergRoom.java
java.lang.IllegalArgumentException: Integer value required, but not specified: treasureCounter!
at org.l2jmobius.gameserver.model.StatSet.getInt(StatSet.java:310)
at org.l2jmobius.gameserver.model.StatSet.increaseInt(StatSet.java:352)
at instances.GolbergRoom.GolbergRoom.onAdvEvent(GolbergRoom.java:129)
at org.l2jmobius.gameserver.model.quest.Quest.notifyEvent(Quest.java:558)
at org.l2jmobius.gameserver.model.quest.QuestTimer$ScheduleTimerTask.run(QuestTimer.java:156)
at org.l2jmobius.commons.concurrent.RunnableWrapper.run(RunnableWrapper.java:38)
at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)
at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
at java.base/java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:304)
at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1130)
at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:630)
at java.base/java.lang.Thread.run(Thread.java:832)
Fix:
---
diff --git a/dist/game/data/scripts/instances/GolbergRoom/GolbergRoom.java b/dist/game/data/scripts/instances/GolbergRoom/GolbergRoom.java
index 749ff98..e14b988 100644
--- a/dist/game/data/scripts/instances/GolbergRoom/GolbergRoom.java
+++ b/dist/game/data/scripts/instances/GolbergRoom/GolbergRoom.java
@@ -119,6 +119,10 @@ public class GolbergRoom extends AbstractInstance
{
return null;
}
+
+ if (world.getParameters().getInt("treasureCounter", 0) == 0) {
+ world.getParameters().set("treasureCounter", 0);
+ }
if (player.isGM())
{
Goldberg's Treasure Chest droplist:
---
dist/game/data/stats/npcs/18300-18399.xml | 68 +++++++++++++++++++++++++++++++
1 file changed, 68 insertions(+)
diff --git a/dist/game/data/stats/npcs/18300-18399.xml b/dist/game/data/stats/npcs/18300-18399.xml
index 2d53a4e..057a815 100644
--- a/dist/game/data/stats/npcs/18300-18399.xml
+++ b/dist/game/data/stats/npcs/18300-18399.xml
@@ -1070,6 +1070,74 @@
<skillList>
<skill id="4416" level="2" /> <!-- Magical Creatures -->
</skillList>
+ <dropLists>
+ <drop>
+ <item id="57" min="200000" max="500000" chance="5"/> <!-- Adena-->
+ <item id="1462" min="1" max="2" chance="2"/> <!-- Cry S -->
+ <item id="1808" min="1" max="1" chance="2"/> <!-- Recipe soulshot S -->
+ <item id="3957" min="1" max="1" chance="2"/> <!-- Recipe Blessed SpiritShot S -->
+ <item id="1888" min="1" max="1" chance="2"/> <!-- Synthetic cokes -->
+ <item id="1894" min="1" max="1" chance="2"/> <!-- Quality leather -->
+ <item id="5553" min="1" max="1" chance="2"/> <!-- Arcsmith Anvil -->
+ <item id="5550" min="1" max="1" chance="2"/> <!-- Reinforced metal plate -->
+ <item id="1889" min="1" max="1" chance="2"/> <!-- Synthetic braid -->
+ <item id="6688" min="1" max="1" chance="0.5"/> <!-- S grade blade -->
+ <item id="6689" min="1" max="1" chance="0.5"/> <!-- S grade blade -->
+ <item id="6690" min="1" max="1" chance="0.5"/> <!-- S grade blade -->
+ <item id="6691" min="1" max="1" chance="0.5"/> <!-- S grade blade -->
+ <item id="6693" min="1" max="1" chance="0.5"/> <!-- S grade blade -->
+ <item id="6694" min="1" max="1" chance="0.5"/> <!-- S grade blade -->
+ <item id="6695" min="1" max="1" chance="0.5"/> <!-- S grade blade -->
+ <item id="6696" min="1" max="1" chance="0.5"/> <!-- S grade blade -->
+ <item id="6697" min="1" max="1" chance="0.5"/> <!-- S grade blade -->
+ <item id="6698" min="1" max="1" chance="0.5"/> <!-- S grade blade -->
+ <item id="6699" min="1" max="1" chance="0.5"/> <!-- S grade blade -->
+ <item id="6847" min="1" max="1" chance="0.5"/> <!-- Recipe S 30% -->
+ <item id="6849" min="1" max="1" chance="0.5"/> <!-- Recipe S 30% -->
+ <item id="6851" min="1" max="1" chance="0.5"/> <!-- Recipe S 30% -->
+ <item id="6853" min="1" max="1" chance="0.5"/> <!-- Recipe S 30% -->
+ <item id="6855" min="1" max="1" chance="0.5"/> <!-- Recipe S 30% -->
+ <item id="6857" min="1" max="1" chance="0.5"/> <!-- Recipe S 30% -->
+ <item id="6859" min="1" max="1" chance="0.5"/> <!-- Recipe S 30% -->
+ <item id="6861" min="1" max="1" chance="0.5"/> <!-- Recipe S 30% -->
+ <item id="6863" min="1" max="1" chance="0.5"/> <!-- Recipe S 30% -->
+ <item id="6865" min="1" max="1" chance="0.5"/> <!-- Recipe S 30% -->
+ <item id="6867" min="1" max="1" chance="0.5"/> <!-- Recipe S 30% -->
+ <item id="6869" min="1" max="1" chance="0.5"/> <!-- Recipe S 30% -->
+ <item id="6871" min="1" max="1" chance="0.5"/> <!-- Recipe S 30% -->
+ <item id="6873" min="1" max="1" chance="0.5"/> <!-- Recipe S 30% -->
+ <item id="6875" min="1" max="1" chance="0.5"/> <!-- Recipe S 30% -->
+ <item id="6877" min="1" max="1" chance="0.5"/> <!-- Recipe S 30% -->
+ <item id="6879" min="1" max="1" chance="0.5"/> <!-- Recipe S 30% -->
+ <item id="6881" min="1" max="1" chance="0.5"/> <!-- Recipe S 30% -->
+ <item id="6883" min="1" max="1" chance="0.5"/> <!-- Recipe S 30% -->
+ <item id="6885" min="1" max="1" chance="0.5"/> <!-- Recipe S 30% -->
+ <item id="6887" min="1" max="1" chance="0.5"/> <!-- Recipe S 30% -->
+ <item id="6891" min="1" max="1" chance="0.5"/> <!-- Recipe S 30% -->
+ <item id="6893" min="1" max="1" chance="0.5"/> <!-- Recipe S 30% -->
+ <item id="6895" min="1" max="1" chance="0.5"/> <!-- Recipe S 30% -->
+ <item id="6897" min="1" max="1" chance="0.5"/> <!-- Recipe S 30% -->
+ <item id="6899" min="1" max="1" chance="0.5"/> <!-- Recipe S 30% -->
+ <item id="2134" min="1" max="1" chance="0.5"/> <!-- Gemstone S -->
+ <item id="6700" min="1" max="1" chance="0.5"/> <!-- S armor and jewel fabric -->
+ <item id="6701" min="1" max="1" chance="0.5"/> <!-- S armor and jewel fabric -->
+ <item id="6702" min="1" max="1" chance="0.5"/> <!-- S armor and jewel fabric -->
+ <item id="6703" min="1" max="1" chance="0.5"/> <!-- S armor and jewel fabric -->
+ <item id="6704" min="1" max="1" chance="0.5"/> <!-- S armor and jewel fabric -->
+ <item id="6705" min="1" max="1" chance="0.5"/> <!-- S armor and jewel fabric -->
+ <item id="6706" min="1" max="1" chance="0.5"/> <!-- S armor and jewel fabric -->
+ <item id="6707" min="1" max="1" chance="0.5"/> <!-- S armor and jewel fabric -->
+ <item id="6708" min="1" max="1" chance="0.5"/> <!-- S armor and jewel fabric -->
+ <item id="6709" min="1" max="1" chance="0.5"/> <!-- S armor and jewel fabric -->
+ <item id="6710" min="1" max="1" chance="0.5"/> <!-- S armor and jewel fabric -->
+ <item id="6711" min="1" max="1" chance="0.5"/> <!-- S armor and jewel fabric -->
+ <item id="6712" min="1" max="1" chance="0.5"/> <!-- S armor and jewel fabric -->
+ <item id="6713" min="1" max="1" chance="0.5"/> <!-- S armor and jewel fabric -->
+ <item id="6714" min="1" max="1" chance="0.5"/> <!-- S armor and jewel fabric -->
+ <item id="91012" min="1" max="1" chance="0.5"/> <!-- Weapon Pack (Best A-grade) -->
+ <item id="49786" min="1" max="1" chance="0.5"/> <!-- Armor Pack (A-grade) -->
+ </drop>
+ </dropLists>
</npc>
<npc id="18358" level="82" type="Monster" name="Goldberg's Steward">
<race>DEMONIC</race>
--
Also missing weapon pack skill:
diff --git a/dist/game/data/stats/items/91000-91099.xml b/dist/game/data/stats/items/91000-91099.xml
index 08089d1..b67a8d7 100644
--- a/dist/game/data/stats/items/91000-91099.xml
+++ b/dist/game/data/stats/items/91000-91099.xml
@@ -129,9 +129,14 @@
<!-- Double-click to obtain 1 A-Grade Weapon best quality. Cannot be dropped. -->
<set name="icon" val="icon.etc_treasure_box_i00" />
<set name="default_action" val="SKILL_REDUCE_ON_SKILL_SUCCESS" />
+ <set name="material" val="PAPER" />
<set name="is_dropable" val="false" />
<set name="is_sellable" val="false" />
<set name="is_stackable" val="true" />
+ <set name="handler" val="ItemSkills" />
+ <skills>
+ <skill id="100001" level="1" /> <!-- Weapon Supply Box (Best A-grade) -->
+ </skills>
</item>
<item id="91013" name="Weapon Ingredient/Recipe Box (Top A-grade)" type="EtcItem">
<!-- Double-click to obtain a top A-grade weapon ingredient or recipe. Cannot be dropped. -->
I have added the skill to the custom folder with 100001 ID:
+++ b/dist/game/data/stats/skills/custom/weapon_box_best_a_grade.xml
@@ -0,0 +1,63 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<list xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="../../../xsd/skills.xsd">
+ <skill id="100001" toLevel="1" name="Weapon Supply Box (A-grade)">
+ <icon>icon.etc_treasure_box_i07</icon>
+ <isMagic>2</isMagic> <!-- Static Skill -->
+ <itemConsumeCount>1</itemConsumeCount>
+ <itemConsumeId>91012</itemConsumeId>
+ <magicLevel>1</magicLevel>
+ <operateType>A1</operateType>
+ <hitTime>500</hitTime>
+ <coolTime>500</coolTime>
+ <reuseDelay>3000</reuseDelay>
+ <magicCriticalRate>5</magicCriticalRate>
+ <hitCancelTime>0</hitCancelTime>
+ <targetType>SELF</targetType>
+ <affectScope>SINGLE</affectScope>
+ <conditions>
+ <condition name="OpEncumbered">
+ <weightPercent>20</weightPercent>
+ <slotsPercent>10</slotsPercent>
+ </condition>
+ </conditions>
+ <effects>
+ <effect name="RestorationRandom">
+ <items>
+ <item chance="9.09">
+ <item id="8678" count="1" /> <!-- Sirra's Blade -->
+ </item>
+ <item chance="9.09">
+ <item id="8679" count="1" /> <!-- Sword of Ipos -->
+ </item>
+ <item chance="9.09">
+ <item id="8680" count="1" /> <!-- Barakiel's Axe -->
+ </item>
+ <item chance="9.09">
+ <item id="8681" count="1" /> <!-- Behemoth' Tuning Fork -->
+ </item>
+ <item chance="9.09">
+ <item id="8682" count="1" /> <!-- Naga Storm -->
+ </item>
+ <item chance="9.09">
+ <item id="8683" count="1" /> <!-- Tiphon's Spear -->
+ </item>
+ <item chance="9.09">
+ <item id="8684" count="1" /> <!-- Shyeed's Bow -->
+ </item>
+ <item chance="9.09">
+ <item id="8685" count="1" /> <!-- Sobekk's Hurricane -->
+ </item>
+ <item chance="9.09">
+ <item id="8686" count="1" /> <!-- Themis' Tongue -->
+ </item>
+ <item chance="9.09">
+ <item id="8687" count="1" /> <!-- Cabrio's Hand -->
+ </item>
+ <item chance="9.09">
+ <item id="8688" count="1" /> <!-- Daimon Crystal -->
+ </item>
+ </items>
+ </effect>
+ </effects>
+ </skill>
+</list>
--
