C6 Bug craft Offline

[snyderjgz]

Hi everyone, I found a kind of bug with the offline crafter.
After about 5 or 6 hours it stops working and does not create any item.

[Mobius]

As far as I know crafting has no time limit.
Need more information on this.

[snyderjgz]

This happens

Log:

Code: [Select]

[22/07 16:36:05] Player or target is not online, aborting player BBBBBBBBBplayer Vecna


[Mobius]

Remove the online check?

Code: [Select]

Index: java/org/l2jmobius/gameserver/RecipeController.java
===================================================================
--- java/org/l2jmobius/gameserver/RecipeController.java (revision 7463)
+++ java/org/l2jmobius/gameserver/RecipeController.java (working copy)
@@ -324,13 +324,6 @@
  return;
  }
 
- if (!_player.isOnline() || !_target.isOnline())
- {
- LOGGER.warning("Player or target is not online, aborting " + _target + _player);
- abort();
- return;
- }
-
  if (Config.ALT_GAME_CREATION && (_activeMakers.get(_player) == null))
  {
  if (_target != _player)


[Mobius]

Did this work?

[snyderjgz]

Did this work?

no, it's still the same

[Mobius]

Any other message?
Because that is the only occurrence of the "Player or target is not online, aborting" message.

[snyderjgz]

Any other message?
Because that is the only occurrence of the "Player or target is not online, aborting" message.

Nope, just that message

[snyderjgz]

Forget it, my mistake. It works

[Mobius]

Fixed with https://bitbucket.org/MobiusDev/l2j_mobius/commits/33472b51beadd322f2175c764fa2f713584f069d