Classic Saviors Destroyer skill Excruciating Strike does an absurd amount of DMG

[valntin]

Two bugs has been discussed here:

https://l2jmobius.org/forum/index.php?topic=2949.msg12165#msg12165

the first one seems to be fixed, but the damage that the skills does hasn't. The skill does 3 time more damage than other destroyer skills with the same power.

Any suggestions on how to balance this skill?

[gamelike85]

"Each skill needs a load time to execute, otherwise the effect is not visible."

make sure each skill has the correct Cooltime and Hit time.

Code: [Select]

<skill id="362" toLevel="1" name="Armor Crush">
<!-- Attacks the enemy with 3077 power, stunning them for 9 sec., their P. Def. -30%, M. Def. -30%. Requires a sword, blunt weapon, two-handed sword, or two-handed blunt weapon. Ignores Shield Defense. Critical. Over-hit. Inflicted status: Confusion (Fear, Aerial Yoke, Faint, Charm, Stun, Paralysis, Knockback, Knockdown, Pull). -->
<icon>icon.skill0362</icon>
<abnormalLvl>2</abnormalLvl>
<abnormalTime>9</abnormalTime>
<abnormalType>STUN</abnormalType>
<abnormalVisualEffect>STUN</abnormalVisualEffect>
<activateRate>40</activateRate>
<basicProperty>PHYSICAL</basicProperty>
<castRange>40</castRange>
<coolTime>400</coolTime>
<effectPoint>-507</effectPoint>
<effectRange>400</effectRange>
<hitTime>2000</hitTime>
<hpConsume>338</hpConsume>
<isDebuff>true</isDebuff>
<lvlBonusRate>20</lvlBonusRate>
<magicLvl>77</magicLvl>
<mpConsume>35</mpConsume>
<nextAction>ATTACK</nextAction>
<operateType>A2</operateType>
<reuseDelay>4000</reuseDelay>
<magicCriticalRate>5</magicCriticalRate>
<trait>SHOCK</trait>
<targetType>ENEMY</targetType>
<affectScope>SINGLE</affectScope>
<conditions>
<condition name="EquipWeapon">
<weaponType>
<item>BLUNT</item>
<item>SWORD</item>
</weaponType>
</condition>
</conditions>
<effects>
<effect name="PhysicalAttack">
<power>3077</power>
<ignoreShieldDefence>true</ignoreShieldDefence>
<criticalChance>20</criticalChance>
<overHit>true</overHit>
</effect>
<effect name="BlockActions">
<allowedSkills>10279;10517;10025;10776;11770;1904;11264;11093;13314;1912</allowedSkills>
</effect>
<effect name="MagicalDefence">
<amount>-30</amount>
<mode>PER</mode>
</effect>
<effect name="PhysicalDefence">
<amount>-30</amount>
<mode>PER</mode>
</effect>
</effects>
</skill>


Use the 3 skills in a row and apply the correct damage each.

[valntin]

I was actually referring the second bug in that thread. That the skill does too much dmg. I checked the XML file for it and all stats seem fine. When I remove the:

<pDefMod>0.2</pDefMod>

20% def ignore definition, the skills starts doing somewhat normal damage. I think the java logic developed for ignoring the p.def is not working as intended.

Code: [Select]

<skill id="1607" toLevel="40" name="Excruciating Strike">
<!-- Attacks the enemies in front of the character with $s1 Power added to P. Atk. Ignores $s2 of the enemy's P. Def. Requires a sword/two-handed sword. Over-hit. Ignores Shield Defense. -->
<icon>icon.skill1607</icon>
<castRange>40</castRange>
<coolTime>500</coolTime>
<effectPoint>
<value level="1">-213</value>
<value level="2">-219</value>
<value level="3">-225</value>
<value level="4">-231</value>
<value level="5">-237</value>
<value level="6">-242</value>
<value level="7">-248</value>
<value level="8">-254</value>
<value level="9">-260</value>
<value level="10">-265</value>
<value level="11">-271</value>
<value level="12">-277</value>
<value level="13">-283</value>
<value level="14">-288</value>
<value level="15">-294</value>
<value level="16">-299</value>
<value level="17">-305</value>
<value level="18">-310</value>
<value level="19">-316</value>
<value level="20">-321</value>
<value level="21">-326</value>
<value level="22">-331</value>
<value level="23">-336</value>
<value level="24">-340</value>
<value level="25">-345</value>
<value level="26">-350</value>
<value level="27">-354</value>
<value level="28">-358</value>
<value level="29">-362</value>
<value level="30">-366</value>
<value level="31">-370</value>
<value level="32">-373</value>
<value level="33">-377</value>
<value level="34">-380</value>
<value level="35">-383</value>
<value level="36">-386</value>
<value level="37">-388</value>
<value level="38">-390</value>
<value level="39">-392</value>
<value level="40">-394</value>
</effectPoint>
<effectRange>400</effectRange>
<hitTime>1900</hitTime>
<magicLvl>
<value level="1">40</value>
<value level="2">40</value>
<value level="3">40</value>
<value level="4">41</value>
<value level="5">42</value>
<value level="6">43</value>
<value level="7">44</value>
<value level="8">45</value>
<value level="9">46</value>
<value level="10">47</value>
<value level="11">48</value>
<value level="12">49</value>
<value level="13">50</value>
<value level="14">51</value>
<value level="15">52</value>
<value level="16">53</value>
<value level="17">54</value>
<value level="18">55</value>
<value level="19">56</value>
<value level="20">57</value>
<value level="21">58</value>
<value level="22">59</value>
<value level="23">60</value>
<value level="24">61</value>
<value level="25">62</value>
<value level="26">63</value>
<value level="27">64</value>
<value level="28">65</value>
<value level="29">66</value>
<value level="30">67</value>
<value level="31">68</value>
<value level="32">69</value>
<value level="33">70</value>
<value level="34">71</value>
<value level="35">72</value>
<value level="36">73</value>
<value level="37">74</value>
<value level="38">76</value>
<value level="39">77</value>
<value level="40">80</value>
</magicLvl>
<mpConsume>
<value level="1">42</value>
<value level="2">43</value>
<value level="3">45</value>
<value level="4">45</value>
<value level="5">46</value>
<value level="6">47</value>
<value level="7">49</value>
<value level="8">50</value>
<value level="9">52</value>
<value level="10">53</value>
<value level="11">55</value>
<value level="12">56</value>
<value level="13">58</value>
<value level="14">58</value>
<value level="15">59</value>
<value level="16">61</value>
<value level="17">62</value>
<value level="18">64</value>
<value level="19">65</value>
<value level="20">67</value>
<value level="21">68</value>
<value level="22">70</value>
<value level="23">71</value>
<value level="24">71</value>
<value level="25">73</value>
<value level="26">74</value>
<value level="27">75</value>
<value level="28">77</value>
<value level="29">78</value>
<value level="30">79</value>
<value level="31">80</value>
<value level="32">82</value>
<value level="33">83</value>
<value level="34">84</value>
<value level="35">85</value>
<value level="36">86</value>
<value level="37">87</value>
<value level="38">94</value>
<value level="39">95</value>
<value level="40">96</value>
</mpConsume>
<nextAction>ATTACK</nextAction>
<operateType>A1</operateType>
<reuseDelay>3000</reuseDelay>
<magicCriticalRate>5</magicCriticalRate>
<targetType>ENEMY</targetType>
<affectScope>SINGLE</affectScope>
<conditions>
<condition name="EquipWeapon">
<weaponType>
<item>SWORD</item>
<item>BLUNT</item>
</weaponType>
</condition>
</conditions>
<effects>
<effect name="PhysicalAttack">
<power>
<value level="1">465</value>
<value level="2">494</value>
<value level="3">525</value>
<value level="4">557</value>
<value level="5">590</value>
<value level="6">625</value>
<value level="7">662</value>
<value level="8">699</value>
<value level="9">738</value>
<value level="10">779</value>
<value level="11">821</value>
<value level="12">864</value>
<value level="13">909</value>
<value level="14">956</value>
<value level="15">1004</value>
<value level="16">1052</value>
<value level="17">1103</value>
<value level="18">1155</value>
<value level="19">1208</value>
<value level="20">1262</value>
<value level="21">1318</value>
<value level="22">1374</value>
<value level="23">1432</value>
<value level="24">1490</value>
<value level="25">1550</value>
<value level="26">1610</value>
<value level="27">1671</value>
<value level="28">1733</value>
<value level="29">1796</value>
<value level="30">1859</value>
<value level="31">1922</value>
<value level="32">1985</value>
<value level="33">2049</value>
<value level="34">2112</value>
<value level="35">2175</value>
<value level="36">2239</value>
<value level="37">2301</value>
<value level="38">2361</value>
<value level="39">2420</value>
<value level="40">2478</value>
</power>
<ignoreShieldDefence>true</ignoreShieldDefence>
<criticalChance>15</criticalChance>
<overHit>true</overHit>
<pDefMod>0.2</pDefMod>
</effect>
</effects>
</skill>


[valntin]

Do you think that pdefmod should be defined like:

<pDefMod>
<value fromLevel="1" toLevel="40">0.2</value>
</pDefMod>

instead

<pDefMod>0.2</pDefMod>

[Iris]

The value is inverted. It should be 0.8 in order to ignore 20% of the target's P. Def.

0.2 means it's ignoring 80% of the target's P. Def.

Change it to 0.8 and the bug is fixed. Then it can be commited @Mobius

[valntin]

Thanks, I will test that a bit later. Also, I noticed that in:

game/data/skillTrees/2ndClass/Destroyer.xml

Code: [Select]

<skill skillName="Excruciating Strike" skillId="1607" skillLvl="10" getLevel="48" levelUpSp="160000" />

is missing and you are unable to learn the skill beyond level 9, so that too needs to be committed in the repo

[Mobius]

The value is inverted. It should be 0.8 in order to ignore 20% of the target's P. Def.

0.2 means it's ignoring 80% of the target's P. Def.

Change it to 0.8 and the bug is fixed. Then it can be commited @Mobius

When I have time ti check multiple branches.
Unless someone else does it.

[Mobius]

Fixed with revision 6425.
Thanks