L2JMobius

C4 [Contribution] NPC Social Aggro Fix

glock · 12 · 699

Offline glock

  • Heir
  • **
    • Posts: 16
The C4 datapack had a widespread issue where NPCs were incorrectly assigned the generic <clan>ALL</clan> tag, causing unrelated race monsters to help each other in combat.
I edited all of the <clan> tags so that social behaviour of the mob functions correctly.

https://gitlab.com/MobiusDevelopment/L2J_Mobius/-/merge_requests/1/commits?commit_id=d69d0373a7c6871faa9c0a9fc1d72218c337cc88


Online Mobius

  • Distinguished King
  • *****
    • Posts: 19655
You confuse clan with race.

Also share diff patches.
We do not do merges.


Offline glock

  • Heir
  • **
    • Posts: 16
I know, I just used race as an example. What I ment to say, a passive beast(bear) should not be social with lets say (undead)skeleton. This fixes that problem.

Idk what you mean by to post patches. So let me know if this is not it. Im new to all of this.
https://gitlab.com/Glockxvii/L2J_Mobius/-/commit/d69d0373a7c6871faa9c0a9fc1d72218c337cc88.patch



Online Mobius

  • Distinguished King
  • *****
    • Posts: 19655

Offline glock

  • Heir
  • **
    • Posts: 16
Even if you adjust agro range. A Bat should never help a zombie and vice versa.
Heres an example. First part of video with original files. Second part with the fix.


Online Naker

  • Count
  • *****
    • Posts: 450
  • Coding Dreams
The data we use is parsed by L2jServer from official files. So if we have clan as all it is what it is for C4. You are free the mod your project as you want but this is not something that player that want a retail server should reproduce. So no need to change at all


Online Mobius

  • Distinguished King
  • *****
    • Posts: 19655
Even if you adjust agro range. A Bat should never help a zombie and vice versa.
Heres an example. First part of video with original files. Second part with the fix.

Says who?
They both have no clan.

Adding clan everywhere because "we must" without retail info, is not going to happen.


Offline glock

  • Heir
  • **
    • Posts: 16
The data we use is parsed by L2jServer from official files. So if we have clan as all it is what it is for C4. You are free the mod your project as you want but this is not something that player that want a retail server should reproduce. So no need to change at all


But even if you attack mobs next to Pixie or Treant NPCs, those NPCs immediately aggro you, because mobs near them have <clan>ALL</clan> which asks for assistance from all nearby mobs, and evidently from NPCs that are aggroable.
You're telling me on official servers even NPCs were attacking players because of killing mobs?


Offline glock

  • Heir
  • **
    • Posts: 16
Says who?
They both have no clan.

Adding clan everywhere because "we must" without retail info, is not going to happen.

They both have no clan? Its literally in your files. Theyr clan tags are all set to "ALL". You can even put Treant NPC next to a zombie. Hit the zombie and the NPC will aggro you.
Im not adding the clan tag everywhere, im just modifying the existing tags so that mobs and NPC wont behave like this.

Anyway Im not here to argue, do as you please with this information.


Online Mobius

  • Distinguished King
  • *****
    • Posts: 19655
Your "information" is invalid and not based on any retail information.
The NPCs currently work as intended.



Online Naker

  • Count
  • *****
    • Posts: 450
  • Coding Dreams

But even if you attack mobs next to Pixie or Treant NPCs, those NPCs immediately aggro you, because mobs near them have <clan>ALL</clan> which asks for assistance from all nearby mobs, and evidently from NPCs that are aggroable.
You're telling me on official servers even NPCs were attacking players because of killing mobs?
Yes this npc you put as example are protector of the area and attack any player that are hunting here is the lore of them... and again what we have is extracted as official.