L2JMobius

Public Development => Shares/Contributions => Committed User Contributions => Topic started by: scrab4ever on December 04, 2025, 12:12:59 PM

Title: Fix for enchant scrolls. Interlude enchant scrolls should not be stackable
Post by: scrab4ever on December 04, 2025, 12:12:59 PM: Enchant scrolls should not be stackable for the Interlude client

Code: (diff) [Select]
diff --git a/dist/game/data/stats/items/00900-00999.xml b/dist/game/data/stats/items/00900-00999.xml index bd401c6e..b1a3ab60 100644 --- a/dist/game/data/stats/items/00900-00999.xml +++ b/dist/game/data/stats/items/00900-00999.xml @@ -721,7 +721,7 @@ <set name="material" val="PAPER" /> <set name="weight" val="120" /> <set name="price" val="500000" /> - <set name="is_stackable" val="true" /> + <set name="is_stackable" val="false" /> <set name="is_oly_restricted" val="true" /> <set name="handler" val="EnchantScrolls" /> <set name="item_skill" val="2015-1" />  @@ -735,7 +735,7 @@ <set name="material" val="PAPER" /> <set name="weight" val="120" /> <set name="price" val="80000" /> - <set name="is_stackable" val="true" /> + <set name="is_stackable" val="false" /> <set name="is_oly_restricted" val="true" /> <set name="handler" val="EnchantScrolls" /> <set name="item_skill" val="2016-1" />  @@ -748,7 +748,7 @@ <set name="immediate_effect" val="true" /> <set name="material" val="PAPER" /> <set name="weight" val="120" /> - <set name="is_stackable" val="true" />  + <set name="is_stackable" val="false" />  <set name="is_oly_restricted" val="true" /> <set name="handler" val="EnchantScrolls" /> <set name="item_skill" val="2015-1" />  @@ -761,7 +761,7 @@ <set name="immediate_effect" val="true" /> <set name="material" val="PAPER" /> <set name="weight" val="120" /> - <set name="is_stackable" val="true" />  + <set name="is_stackable" val="false" />  <set name="is_oly_restricted" val="true" /> <set name="handler" val="EnchantScrolls" /> <set name="item_skill" val="2016-1" />  @@ -775,7 +775,7 @@ <set name="material" val="PAPER" /> <set name="weight" val="120" /> <set name="price" val="110000" /> - <set name="is_stackable" val="true" /> + <set name="is_stackable" val="false" /> <set name="is_oly_restricted" val="true" /> <set name="handler" val="EnchantScrolls" /> <set name="item_skill" val="2017-1" />  @@ -789,7 +789,7 @@ <set name="material" val="PAPER" /> <set name="weight" val="120" /> <set name="price" val="15000" /> - <set name="is_stackable" val="true" /> + <set name="is_stackable" val="false" /> <set name="is_oly_restricted" val="true" /> <set name="handler" val="EnchantScrolls" /> <set name="item_skill" val="2018-1" />  @@ -802,7 +802,7 @@ <set name="immediate_effect" val="true" /> <set name="material" val="PAPER" /> <set name="weight" val="120" /> - <set name="is_stackable" val="true" />  + <set name="is_stackable" val="false" />  <set name="is_oly_restricted" val="true" /> <set name="handler" val="EnchantScrolls" /> <set name="item_skill" val="2017-1" />  @@ -815,7 +815,7 @@ <set name="immediate_effect" val="true" /> <set name="material" val="PAPER" /> <set name="weight" val="120" /> - <set name="is_stackable" val="true" />  + <set name="is_stackable" val="false" />  <set name="is_oly_restricted" val="true" /> <set name="handler" val="EnchantScrolls" /> <set name="item_skill" val="2018-1" />  @@ -829,7 +829,7 @@ <set name="material" val="PAPER" /> <set name="weight" val="120" /> <set name="price" val="50000" /> - <set name="is_stackable" val="true" /> + <set name="is_stackable" val="false" /> <set name="is_oly_restricted" val="true" /> <set name="handler" val="EnchantScrolls" /> <set name="item_skill" val="2019-1" />  @@ -843,7 +843,7 @@ <set name="material" val="PAPER" /> <set name="weight" val="120" /> <set name="price" val="6000" /> - <set name="is_stackable" val="true" /> + <set name="is_stackable" val="false" /> <set name="is_oly_restricted" val="true" /> <set name="handler" val="EnchantScrolls" /> <set name="item_skill" val="2020-1" />  @@ -856,7 +856,7 @@ <set name="immediate_effect" val="true" /> <set name="material" val="PAPER" /> <set name="weight" val="120" /> - <set name="is_stackable" val="true" />  + <set name="is_stackable" val="false" />  <set name="is_oly_restricted" val="true" /> <set name="handler" val="EnchantScrolls" /> <set name="item_skill" val="2019-1" />  @@ -869,7 +869,7 @@ <set name="immediate_effect" val="true" /> <set name="material" val="PAPER" /> <set name="weight" val="120" /> - <set name="is_stackable" val="true" />  + <set name="is_stackable" val="false" />  <set name="is_oly_restricted" val="true" /> <set name="handler" val="EnchantScrolls" /> <set name="item_skill" val="2020-1" />  @@ -883,7 +883,7 @@ <set name="material" val="PAPER" /> <set name="weight" val="120" /> <set name="price" val="5000000" /> - <set name="is_stackable" val="true" /> + <set name="is_stackable" val="false" /> <set name="is_oly_restricted" val="true" /> <set name="handler" val="EnchantScrolls" /> <set name="item_skill" val="2021-1" />  @@ -897,7 +897,7 @@ <set name="material" val="PAPER" /> <set name="weight" val="120" /> <set name="price" val="500000" /> - <set name="is_stackable" val="true" /> + <set name="is_stackable" val="false" /> <set name="is_oly_restricted" val="true" /> <set name="handler" val="EnchantScrolls" /> <set name="item_skill" val="2022-1" />  @@ -910,7 +910,7 @@ <set name="immediate_effect" val="true" /> <set name="material" val="PAPER" /> <set name="weight" val="120" /> - <set name="is_stackable" val="true" />  + <set name="is_stackable" val="false" />  <set name="is_oly_restricted" val="true" /> <set name="handler" val="EnchantScrolls" /> <set name="item_skill" val="2021-1" />  @@ -923,7 +923,7 @@ <set name="immediate_effect" val="true" /> <set name="material" val="PAPER" /> <set name="weight" val="120" /> - <set name="is_stackable" val="true" />  + <set name="is_stackable" val="false" />  <set name="is_oly_restricted" val="true" /> <set name="handler" val="EnchantScrolls" /> <set name="item_skill" val="2022-1" />
Title: Re: Fix for enchant scrolls. Interlude enchant scrolls should not be stackable
Post by: Mobius on December 04, 2025, 12:33:41 PM: Interlude enchant scrolls are not stackable?
Title: Re: Fix for enchant scrolls. Interlude enchant scrolls should not be stackable
Post by: scrab4ever on December 04, 2025, 01:36:30 PM: No sir, they are not! They can be stacked if the config is set as such ,but there is no (x) in the inventory displaying the quantity.

Also:
(https://www.hostimage.org/images/2025/12/04/Capture.jpg)

**I am not saying that they are not stackable because chatgpt says it.
I say they are not stackabe because:

1) i remember it was never stackable
2) in my local server, using a non modified client, scrolls do not display amount on the icon.

I would guess that for the previous client versions. enchant scrolls are not stackable aswell
Title: Re: Fix for enchant scrolls. Interlude enchant scrolls should not be stackable
Post by: emilianoify on December 05, 2025, 05:00:44 PM: Wow, I didn't remember that, but it's true. I recall old forums where it needed to be implemented as a custom feature.
Title: Re: Fix for enchant scrolls. Interlude enchant scrolls should not be stackable
Post by: scrab4ever on December 08, 2025, 08:43:33 PM: Also:

Code: (diff) [Select]
diff --git a/dist/game/data/stats/items/00700-00799.xml b/dist/game/data/stats/items/00700-00799.xml index 23d0ab75..dba32b56 100644 --- a/dist/game/data/stats/items/00700-00799.xml +++ b/dist/game/data/stats/items/00700-00799.xml @@ -414,7 +414,7 @@ <set name="material" val="PAPER" /> <set name="weight" val="120" /> <set name="price" val="1800000" /> - <set name="is_stackable" val="true" /> + <set name="is_stackable" val="false" /> <set name="is_oly_restricted" val="true" /> <set name="handler" val="EnchantScrolls" /> <set name="item_skill" val="2006-1" />  @@ -428,7 +428,7 @@ <set name="material" val="PAPER" /> <set name="weight" val="120" /> <set name="price" val="240000" /> - <set name="is_stackable" val="true" /> + <set name="is_stackable" val="false" /> <set name="is_oly_restricted" val="true" /> <set name="handler" val="EnchantScrolls" /> <set name="item_skill" val="2007-1" />  @@ -441,7 +441,7 @@ <set name="immediate_effect" val="true" /> <set name="material" val="PAPER" /> <set name="weight" val="120" /> - <set name="is_stackable" val="true" />  + <set name="is_stackable" val="false" />  <set name="is_oly_restricted" val="true" /> <set name="handler" val="EnchantScrolls" /> <set name="item_skill" val="2006-1" />  @@ -454,7 +454,7 @@ <set name="immediate_effect" val="true" /> <set name="material" val="PAPER" /> <set name="weight" val="120" /> - <set name="is_stackable" val="true" />  + <set name="is_stackable" val="false" />  <set name="is_oly_restricted" val="true" /> <set name="handler" val="EnchantScrolls" /> <set name="item_skill" val="2007-1" />
Title: Re: Fix for enchant scrolls. Interlude enchant scrolls should not be stackable
Post by: Reanimation on December 16, 2025, 04:16:42 PM: Quote from: scrab4ever on December 04, 2025, 01:36:30 PM
No sir, they are not! They can be stacked if the config is set as such ,but there is no (x) in the inventory displaying the quantity.

Also:
(https://www.hostimage.org/images/2025/12/04/Capture.jpg)

**I am not saying that they are not stackable because chatgpt says it.
I say they are not stackabe because:

1) i remember it was never stackable
2) in my local server, using a non modified client, scrolls do not display amount on the icon.

I would guess that for the previous client versions. enchant scrolls are not stackable aswell

It's not very difficult to do; in fact, I think nowadays anyone starting out with their first server can make enchant scrolls stackable in their inventory. It's as simple as copying the lines for the scape scrolls and enchant scrolls into the system file, specifically the etcgrp.dat, to make them identical. That is, the enchants should be the same as the scape scrolls, and that's it. Now you have one enchant scroll slot in your inventory with the (x) quantity option, so you don't fill up your inventory unnecessarily and you save slots.
Title: Re: Fix for enchant scrolls. Interlude enchant scrolls should not be stackable
Post by: scrab4ever on December 18, 2025, 06:53:00 AM: Yup, but as far as i understand, this project tries to get as close as possible to the retail features, so imo enchant scrolls (and spellbooks/amulets, in my other post) should not be stackable
Title: Re: Fix for enchant scrolls. Interlude enchant scrolls should not be stackable
Post by: Reanimation on December 18, 2025, 08:00:26 PM: Quote from: scrab4ever on December 18, 2025, 06:53:00 AM
Yup, but as far as i understand, this project tries to get as close as possible to the retail features, so imo enchant scrolls (and spellbooks/amulets, in my other post) should not be stackable

Friend, if we're going to do it that way, then we have to delete the entire config and scripts folder from the data and source, if we're going to try to be as close to the minimum details as possible.

But like all configurations, they're there to be used whether you want to or not; that's why the configuration has the option to enable or disable them. And you don't need to mess with the code and break it just because you want to stick to a comment.🤦🏻🤦🏻

Furthermore, with a minimum of basic client experience, it is known that the more you load into the inventory, the greater the load on the client cache and the lower the performance; therefore, this configuration is not just a whim to emulate the most current chronicles.

Simply put, like everything else, the project is free and everyone can use it as they wish. That doesn't give you the right to impose your will. Work like most people do, privately, and if there's a truly critical error or bug, report it. If you fix it, share the solution, because the goal is for everyone to help and improve the project.
Title: Re: Fix for enchant scrolls. Interlude enchant scrolls should not be stackable
Post by: scrab4ever on December 19, 2025, 11:52:00 PM: I appreciate the time you spent on you response, but you need to read what i said a second time.

"so imo enchant scrolls (and spellbooks/amulets, in my other post) should not be stackable". I impose nothing to no one soul in it.

also "The primary goal of this project is to replicate the retail functionality of the English EU servers"
here: https://l2jmobius.org/forum/index.php?topic=9471.0 (https://l2jmobius.org/forum/index.php?topic=9471.0)

also the scroll icons are already loaded in RAM, so it is just displayed multiple times. No extra stuff (at least for the client)
Title: Re: Fix for enchant scrolls. Interlude enchant scrolls should not be stackable
Post by: infernal on January 22, 2026, 11:32:55 AM: don't forget about the blessed scrolls
Title: Re: Fix for enchant scrolls. Interlude enchant scrolls should not be stackable
Post by: scrab4ever on January 25, 2026, 01:07:52 PM: Quote from: infernal on January 22, 2026, 11:32:55 AM
don't forget about the blessed scrolls

It is already done! :)
Title: Re: Fix for enchant scrolls. Interlude enchant scrolls should not be stackable
Post by: Mobius on January 30, 2026, 12:38:31 AM: Committed with https://gitlab.com/MobiusDevelopment/L2J_Mobius/-/commit/6dcdf5df0bc6c555ea205787eeaef44f8f87a674
Thanks :D