L2JMobius

Public Development => General Discussion => Topic started by: klz on March 10, 2025, 08:26:21 PM

Title: Party invite locks target / autoattack
Post by: klz on March 10, 2025, 08:26:21 PM

Hey guys. I'm facing an issue while trying to target / autoattack a npc while i'm being invited to a party.

Is this happening to you too? Just want to double check before reporting it as a bug. I'm attaching the packet debug terminal also.

Title: Re: Party invite locks target / autoattack
Post by: klz on March 11, 2025, 03:55:45 AM

Ok I finally found where the issue was.

in java/org/l2jmobius/gameserver/network/clientpackets/Action.java

commented out this line:

Code: [Select]

// Check if the target is valid, if the player haven't a shop or isn't the requester of a transaction (ex : FriendInvite, JoinAlly, JoinParty...)
/*
* if (player.getActiveRequester() != null) { // Actions prohibited when in trade player.sendPacket(ActionFailed.STATIC_PACKET); return; }
 */

Don't know if i'm breaking something else but it now allows me to attack while i'm being invited to a party or offered a trade.

Title: Re: Party invite locks target / autoattack
Post by: Liamxroy on March 11, 2025, 08:03:48 AM

Quote from: klz on March 11, 2025, 03:55:45 AM

Ok I finally found where the issue was.

in java/org/l2jmobius/gameserver/network/clientpackets/Action.java

commented out this line:

Code: [Select]

// Check if the target is valid, if the player haven't a shop or isn't the requester of a transaction (ex : FriendInvite, JoinAlly, JoinParty...)
/*
* if (player.getActiveRequester() != null) { // Actions prohibited when in trade player.sendPacket(ActionFailed.STATIC_PACKET); return; }
 */

Don't know if i'm breaking something else but it now allows me to attack while i'm being invited to a party or offered a trade.

add a check if is not autoplaying there.

Code: [Select]

### Eclipse Workspace Patch 1.0
#P L2J_Mobius_CT_0_Interlude
diff --git java/org/l2jmobius/gameserver/network/clientpackets/Action.java java/org/l2jmobius/gameserver/network/clientpackets/Action.java
index 31c3ec1..eee6fb0 100644
--- java/org/l2jmobius/gameserver/network/clientpackets/Action.java
+++ java/org/l2jmobius/gameserver/network/clientpackets/Action.java
@@ -111,7 +111,7 @@
  }
 
  // Check if the target is valid, if the player haven't a shop or isn't the requester of a transaction (ex : FriendInvite, JoinAlly, JoinParty...)
- if (player.getActiveRequester() != null)
+ if ((player.getActiveRequester() != null) && !player.isAutoPlaying())
  {
  // Actions prohibited when in trade
  player.sendPacket(ActionFailed.STATIC_PACKET);