L2JMobius

Dwelling of Spirits Boxes,Scroll,Pack's Missing Items & Item fixes

AngelShade · 6 · 4032

Offline AngelShade

  • Vassal
  • *
    • Posts: 4
Hello forum, i have been enjoying using this server to play with my friends over Radmin VPN and found some issues with the latest release .

If anyone is kind to help me with some pointers where to look file wise i would much appreciate the help . Thank you in advance

I - Stuff that i have found and manage to fix it - tested it and working .


Edit: 1 -*Missing the items that needs to be given when - *\game\data\stats\items\95700-95799.xml
Code: [Select]
<item id="95724" name="Daily Enchant Scroll Pack" type="EtcItem">
<!-- Double-click to obtain one of the following items. -->
<set name="icon" val="icon.etc_bm_jewelbox_main_i00" />
<set name="default_action" val="PEEL" />
<set name="immediate_effect" val="true" />
<set name="material" val="FISH" />
<set name="is_tradable" val="false" />
<set name="is_dropable" val="false" />
<set name="is_sellable" val="false" />
<set name="handler" val="ExtractableItems"/>
<set name="extractableCountMin" val="1" />
<set name="extractableCountMax" val="1" />
<capsuled_items>
<item id="93255" min="1" max="1" chance="6.66"/> <!-- Improved Scroll: Enchant A-grade Weapon -->
<item id="93256" min="1" max="1" chance="6.66"/> <!-- Improved Scroll: Enchant A-grade Armor -->
<item id="93257" min="1" max="1" chance="6.66"/> <!-- Cursed Scroll: Enchant A-grade Weapon -->
<item id="93258" min="1" max="1" chance="6.66"/> <!-- Cursed Scroll: Enchant A-grade Armor -->
<item id="729" min="1" max="1" chance="6.66"/> <!-- Scroll: Enchant A-grade Weapon -->
<item id="730" min="1" max="1" chance="6.66"/> <!-- Scroll: Enchant A-grade Armor -->
<item id="947" min="1" max="1" chance="6.66"/> <!-- Scroll: Enchant B-grade Weapon -->
<item id="948" min="1" max="1" chance="6.66"/> <!-- Scroll: Enchant B-grade Armor -->
<item id="951" min="1" max="1" chance="6.66"/> <!-- Scroll: Enchant C-grade Weapon -->
<item id="952" min="1" max="1" chance="6.66"/> <!-- Scroll: Enchant C-grade Armor -->
<item id="955" min="1" max="1" chance="6.66"/> <!-- Scroll: Enchant D-grade Weapon -->
<item id="956" min="1" max="1" chance="6.66"/> <!-- Scroll: Enchant D-grade Weapon -->
</capsuled_items>
</item>

*Missing the items that needs to be given when - C:\1.) L2 Essence Server\game\data\stats\items\94700-94799.xml
</item>
<item id="94765" name="Lv. 90 Achievement Reward Box" type="EtcItem">
<!-- Double-click to obtain the following items. -->
<set name="icon" val="BranchSys.icon.br_four_leaf_clover_box_i00" />
<set name="default_action" val="PEEL" />
<set name="immediate_effect" val="true" />
<set name="material" val="FISH" />
<set name="is_tradable" val="false" />
<set name="is_dropable" val="false" />
<set name="is_sellable" val="false" />
<set name="handler" val="ExtractableItems"/>
<set name="extractableCountMin" val="1" />
<set name="extractableCountMax" val="1" />
<capsuled_items>
<item id="94047" min="1" max="1" chance="100"/> <!-- Spellbook: Glorious Warrior's Ability Sealed -->
<item id="94042" min="1" max="1" chance="100"/> <!-- Appearance Stone: Emerald Weapon Sealed -->
<item id="94755" min="1" max="1" chance="100"/> <!-- Half Mask of Glory Sealed -->
<item id="94764" min="1" max="1" chance="100"/> <!-- Stylish Color Title Sealed -->
                </capsuled_items>
</item>

Edit : 2 - *Corrected Wrong item for Game Assistant - Armor - +4 Armor - production in *\game\data\multisell\3247831.xml -> Corrected it by adding the correct id to consume " <ingredient count="1" id="94734" /> " to all that are in this file
Warning DO NOT COPY EVERYTHING - Might give a error into your server - i tried doing this with other files and it seems it doesn't copy the correct format , try to copy only what you see
Code: [Select]
<npcs>
<npc>-1</npc> <!-- Dimensional Merchant / Everywhere -->
</npcs>
<!-- Exchange Armor C-Grade -->
<item>
<!-- Enchanted C-grade Armor Coupon -->
<ingredient count="1" id="94734" />
<!-- Highest Quality Armor Set (C-grade) Chest +4 Heavy Armor -->
<production count="1" id="91707" />
</item>
<item>
<!-- Enchanted C-grade Armor Coupon -->
<ingredient count="1" id="94734" />
<!-- Highest Quality Armor Set (C-grade) Chest +4 Leather Armor -->
<production count="1" id="91708" />
</item>
<item>
<!-- Enchanted C-grade Armor Coupon -->
<ingredient count="1" id="94734" />
<!-- Highest Quality Armor Set (C-grade) Chest +4 Robe Armor -->
<production count="1" id="91709" />
</item>

Edit : 3 - Fixed Berseker's Scroll skill -  Warning , i'm using <abnormalType>MULTI_BUFF</abnormalType> - which is used on several other scrolls , if anyone know what class,operator should be used here instead of "MULTI_BUFF" please let me know i want to change it on my local server as well
Code: [Select]
C:\1.) L2 Essence Server\game\data\stats\skills\40200-40299.xml - Location where the changes were made
<skill id="40258" toLevel="1" name="Berserker's Scroll (Exchangeable)">
<!-- STR $s1 INT $s1 Atk. Spd. $s2 Casting Spd. $s2 Speed $s3 P. Skill Power $s4 M. Skill Power $s4 -->
<abnormalLevel>4</abnormalLevel>
<abnormalTime>1200</abnormalTime>
<abnormalType>MULTI_BUFF</abnormalType>
<itemConsumeCount>1</itemConsumeCount>
<itemConsumeId>94776</itemConsumeId>
<hitTime>1000</hitTime>
<isMagic>2</isMagic> <!-- Static Skill -->
<magicLevel>1</magicLevel>
<operateType>A2</operateType>
<basicProperty>NONE</basicProperty>
<magicCriticalRate>5</magicCriticalRate>
<targetType>SELF</targetType>
<affectScope>SINGLE</affectScope>
<stayAfterDeath>true</stayAfterDeath>
<effects>
<effect name="StatUp">
<amount>1</amount>
<stat>STR</stat>
</effect>
<effect name="StatUp">
<amount>1</amount>
<stat>INT</stat>
</effect>
<effect name="PhysicalAttackSpeed">
<amount>100</amount>
<mode>DIFF</mode>
</effect>
<effect name="MagicalAttackSpeed">
<amount>100</amount>
<mode>DIFF</mode>
</effect>
<effect name="Speed">
<amount>20</amount>
<mode>DIFF</mode>
</effect>
<effect name="PhysicalSkillPower">
<amount>5</amount>
<mode>PER</mode>
</effect>
<effect name="MagicalSkillPower">
<amount>5</amount>
<mode>PER</mode>
</effect>
</effects>
</skill>
<skill id="40259" toLevel="1" name="Berserker's Scroll">
<!-- STR $s1 INT $s1 Atk. Spd. $s2 Casting Spd. $s2 Speed $s3 P. Skill Power $s4 M. Skill Power $s4 -->
<abnormalLevel>4</abnormalLevel>
<abnormalTime>1200</abnormalTime>
<abnormalType>MULTI_BUFF</abnormalType>
<itemConsumeCount>1</itemConsumeCount>
<itemConsumeId>94777</itemConsumeId>
<hitTime>1000</hitTime>
<isMagic>2</isMagic> <!-- Static Skill -->
<magicLevel>1</magicLevel>
<operateType>A2</operateType>
<basicProperty>NONE</basicProperty>
<magicCriticalRate>5</magicCriticalRate>
<targetType>SELF</targetType>
<affectScope>SINGLE</affectScope>
<stayAfterDeath>true</stayAfterDeath>
<effects>
<effect name="StatUp">
<amount>1</amount>
<stat>STR</stat>
</effect>
<effect name="StatUp">
<amount>1</amount>
<stat>INT</stat>
</effect>
<effect name="PhysicalAttackSpeed">
<amount>100</amount>
<mode>DIFF</mode>
</effect>
<effect name="MagicalAttackSpeed">
<amount>100</amount>
<mode>DIFF</mode>
</effect>
<effect name="Speed">
<amount>20</amount>
<mode>DIFF</mode>
</effect>
<effect name="PhysicalSkillPower">
<amount>5</amount>
<mode>PER</mode>
</effect>
<effect name="MagicalSkillPower">
<amount>5</amount>
<mode>PER</mode>
</effect>
</effects>
</skill>

------------------ Bug reporting that i don't know how to fix -------------

Issue 1: Kamael Soul Chase skill isn't used when using Auto-hunting , gonna try to remove the range restriction and come back to this, maybe its because of it.
I'm not talking about Monsters but NPC you can speak with.

Issue 2: Magic skills will attack any NPC if Auto-use is enabled and you select Any NPC- i do not know who needs to check that npcs aren't  monsters - and if anyone know where i should look for this , i would much appreciate it
* Above issue applies to summoned pets - they will attack if you select Any NPC

Issue 3:  Cannot find the right file so that i can add Auto-Use available to the custom Newbie MP Recovery Potion with  id="728"
* I've looked into the item of HP potion and the skill it uses , but there's no mention or who handles this type of mechanic. If anyone can tell me which file to look for i would appreciate it.

Issue 4: *\game\data\scripts\quests\Q10296_LetsPayRespectsToOurFallenBrethren\Q10296_LetsPayRespectsToOurFallenBrethren.java
This quest doesn't update ingame the number of monsters you kill, only if you reach the level. But in the Database the number of kills are updated.

Issue 5: *\game\data\scripts\quests\Q10294_SporeInfestedPlace\Q10294_SporeInfestedPlace.java
This quest cannot be finished , something is wrong when you should get the reward, the final condition for completion is done but when you talk to the npc, it tells you *\game\data\scripts\quests\Q10294_SporeInfestedPlace\30857-01.html exactly what in this.

Issue 6: Moving any skills on the shortcut bar - will remove the glowing check on ALL THE SKILLS, that the skill/item is on auto-use (im guessing this is not recorded anywhere and it should be in the db - i guess ).

Issue 7: Removing any skills on the shortcut bar - Will remove the glowing check on ALL THE SKILLS, that the skill/item is on auto-use and also that skill will still be used by Auto-Hunting or When Auto-Hunting is off and you select a Monster .

I will edit this when i find something else .



Online Mobius

  • Distinguished King
  • *****
    • Posts: 16130

Offline AngelShade

  • Vassal
  • *
    • Posts: 4
... i wish i knew how to do that :) , im not using the github , and i have a rev already from a friend , i havent used a packer in a decade now , and my memory left me on how to upload it to github. i can post the whole thing here if thats okay with forum rules tho.
==============================
Edit 1 : Updated first post with fixes i could do .

Edit 2 : Updated with some more fixes - and rearrange the topic to be more clean



Offline AngelShade

  • Vassal
  • *
    • Posts: 4
Oh i'm 100% sure i'm not using the files you currently have on latest revision for subscribed people.

I will do that just now, thank god you have the project installation as a tutorial to install it :)


Online Mobius

  • Distinguished King
  • *****
    • Posts: 16130
Patch for Daily Enchant Scroll Pack (95724).
Code: [Select]
Index: dist/game/data/stats/items/95700-95799.xml
===================================================================
--- dist/game/data/stats/items/95700-95799.xml (revision 9170)
+++ dist/game/data/stats/items/95700-95799.xml (working copy)
@@ -453,6 +453,23 @@
  <set name="is_tradable" val="false" />
  <set name="is_dropable" val="false" />
  <set name="is_sellable" val="false" />
+ <set name="handler" val="ExtractableItems"/>
+ <set name="extractableCountMin" val="1" />
+ <set name="extractableCountMax" val="1" />
+ <capsuled_items>
+ <item id="93255" min="1" max="1" chance="6.66"/> <!-- Improved Scroll: Enchant A-grade Weapon -->
+ <item id="93256" min="1" max="1" chance="6.66"/> <!-- Improved Scroll: Enchant A-grade Armor -->
+ <item id="93257" min="1" max="1" chance="6.66"/> <!-- Cursed Scroll: Enchant A-grade Weapon -->
+ <item id="93258" min="1" max="1" chance="6.66"/> <!-- Cursed Scroll: Enchant A-grade Armor -->
+ <item id="729" min="1" max="1" chance="6.66"/> <!-- Scroll: Enchant A-grade Weapon -->
+ <item id="730" min="1" max="1" chance="6.66"/> <!-- Scroll: Enchant A-grade Armor -->
+ <item id="947" min="1" max="1" chance="6.66"/> <!-- Scroll: Enchant B-grade Weapon -->
+ <item id="948" min="1" max="1" chance="6.66"/> <!-- Scroll: Enchant B-grade Armor -->
+ <item id="951" min="1" max="1" chance="6.66"/> <!-- Scroll: Enchant C-grade Weapon -->
+ <item id="952" min="1" max="1" chance="6.66"/> <!-- Scroll: Enchant C-grade Armor -->
+ <item id="955" min="1" max="1" chance="6.66"/> <!-- Scroll: Enchant D-grade Weapon -->
+ <item id="956" min="1" max="1" chance="6.66"/> <!-- Scroll: Enchant D-grade Weapon -->
+ </capsuled_items>
  </item>
  <item id="95725" name="Frost Lord's Sword" type="Weapon">
  <set name="icon" val="icon.frozen_weapon_sword" />