Classic Zaken Solid Scrolls

[YulRun]

Bug: Solid Scrolls still crystallize equipment
Tested: All Solid Scrolls Armor/Weapon grades D through A

How they should work: Should keep current enchant on fail.

[G-hamsteR]

Check this file: https://bitbucket.org/MobiusDev/l2j_mobius/src/master/L2J_Mobius_Classic_2.1_Zaken/java/org/l2jmobius/gameserver/network/clientpackets/RequestEnchantItem.java

Line 264

Code: [Select]

if (scrollTemplate.isSafe())
Find out what isSafe() means and hot to register solid scrolls as safe.

[YulRun]

Solution Diff (Gist): https://gist.github.com/yulrun/30c6268fb6fb813c77eaedad9a08aafb

Code: [Select]

diff --git a/L2J_Mobius_Classic_2.1_Zaken/java/org/l2jmobius/gameserver/model/items/enchant/EnchantScroll.java b/L2J_Mobius_Classic_2.1_Zaken/java/org/l2jmobius/gameserver/model/items/enchant/EnchantScroll.java
index 25891cc..7c04a8e 100644
--- a/L2J_Mobius_Classic_2.1_Zaken/java/org/l2jmobius/gameserver/model/items/enchant/EnchantScroll.java
+++ b/L2J_Mobius_Classic_2.1_Zaken/java/org/l2jmobius/gameserver/model/items/enchant/EnchantScroll.java
@@ -48,7 +48,7 @@
  final ItemType type = getItem().getItemType();
  _isWeapon = (type == EtcItemType.ENCHT_ATTR_ANCIENT_CRYSTAL_ENCHANT_WP) || (type == EtcItemType.BLESS_ENCHT_WP) || (type == EtcItemType.ENCHT_WP) || (type == EtcItemType.GIANT_ENCHT_WP);
  _isBlessed = (type == EtcItemType.BLESS_ENCHT_AM) || (type == EtcItemType.BLESS_ENCHT_WP);
- _isSafe = (type == EtcItemType.ENCHT_ATTR_CRYSTAL_ENCHANT_AM) || (type == EtcItemType.ENCHT_ATTR_CRYSTAL_ENCHANT_WP);
+ _isSafe = (type == EtcItemType.ENCHT_ATTR_ANCIENT_CRYSTAL_ENCHANT_WP) || (type == EtcItemType.ENCHT_ATTR_ANCIENT_CRYSTAL_ENCHANT_AM) || (type == EtcItemType.ENCHT_ATTR_CRYSTAL_ENCHANT_AM) || (type == EtcItemType.ENCHT_ATTR_CRYSTAL_ENCHANT_WP);
  _isGiant = (type == EtcItemType.GIANT_ENCHT_AM) || (type == EtcItemType.GIANT_ENCHT_WP);
  }


[Mobius]

Committed with a few additional changes with https://bitbucket.org/MobiusDev/l2j_mobius/commits/be6e56f85b68566f4e57f37190ed373e362cdc6e
Thanks