L2JMobius

Free Users => Solved/Invalid Bug Reports => Topic started by: snyderjgz on July 12, 2020, 11:42:15 PM

Title: Bug craft Offline
Post by: snyderjgz on July 12, 2020, 11:42:15 PM

Hi everyone, I found a kind of bug with the offline crafter.
After about 5 or 6 hours it stops working and does not create any item.

Title: Re: Bug craft Offline
Post by: Mobius on July 13, 2020, 04:55:56 AM

As far as I know crafting has no time limit.
Need more information on this.

Title: Re: Bug craft Offline
Post by: snyderjgz on July 23, 2020, 02:43:09 AM

This happens

Log:

Code: [Select]

[22/07 16:36:05] Player or target is not online, aborting player BBBBBBBBBplayer Vecna

(https://i.imgur.com/VsQEJ0x.jpg)
(https://i.imgur.com/0WwK1WP.jpg)

Title: Re: Bug craft Offline
Post by: Mobius on July 23, 2020, 05:57:05 AM

Remove the online check?

Code: [Select]

Index: java/org/l2jmobius/gameserver/RecipeController.java
===================================================================
--- java/org/l2jmobius/gameserver/RecipeController.java (revision 7463)
+++ java/org/l2jmobius/gameserver/RecipeController.java (working copy)
@@ -324,13 +324,6 @@
  return;
  }
 
- if (!_player.isOnline() || !_target.isOnline())
- {
- LOGGER.warning("Player or target is not online, aborting " + _target + _player);
- abort();
- return;
- }
-
  if (Config.ALT_GAME_CREATION && (_activeMakers.get(_player) == null))
  {
  if (_target != _player)


Title: Re: Bug craft Offline
Post by: Mobius on July 24, 2020, 07:55:19 AM

Did this work?

Title: Re: Bug craft Offline
Post by: snyderjgz on July 25, 2020, 12:49:52 AM

Quote from: Mobius on July 24, 2020, 07:55:19 AM

Did this work?

no, it's still the same

Title: Re: Bug craft Offline
Post by: Mobius on July 25, 2020, 01:52:51 AM

Any other message?
Because that is the only occurrence of the "Player or target is not online, aborting" message.

Title: Re: Bug craft Offline
Post by: snyderjgz on July 25, 2020, 02:10:26 AM

Quote from: Mobius on July 25, 2020, 01:52:51 AM

Any other message?
Because that is the only occurrence of the "Player or target is not online, aborting" message.

Nope, just that message

Title: Re: Bug craft Offline
Post by: snyderjgz on July 25, 2020, 02:11:32 AM

Forget it, my mistake. It works

Title: Re: Bug craft Offline
Post by: Mobius on August 01, 2020, 08:48:23 PM

Fixed with https://bitbucket.org/MobiusDev/l2j_mobius/commits/33472b51beadd322f2175c764fa2f713584f069d