L2JMobius

Free Users => Solved/Invalid Bug Reports => Topic started by: kinghanker on April 18, 2022, 05:31:15 AM

Title: Multi relation packet
Post by: kinghanker on April 18, 2022, 05:31:15 AM

During a siege I had these messages and I still don't understand the reason for them, can anyone help?

(https://i.imgur.com/QWYEp9c.jpg)

Title: Re: Multi relation packet
Post by: Mobius on April 18, 2022, 08:18:43 AM

Warnings should be posted on Bug Reports section.
Moved.

Other than that the message is self explanatory.
Invisible character cannot send relation to players because he is invisible.

Title: Re: Multi relation packet
Post by: kinghanker on April 19, 2022, 03:57:50 AM

I got this! what I didn't understand was the trigger made by: RequestRestartPoint
When the character no longer has the castle, the option to return to the castle must disappear and in many cases during the siege or even after the clan that loses the castle usually still has the "to castle" option available.
I don't know if this is the case but wouldn't it be feasible to have a different action for the player that is invisible? make it visible for example?

Title: Re: Multi relation packet
Post by: Mobius on April 19, 2022, 10:30:41 AM

The invisible player is probably a GM.

Title: Re: Multi relation packet
Post by: kinghanker on April 20, 2022, 06:49:05 AM

it was none of the GMs. Staff gms are named with the initial "GM_"

Title: Re: Multi relation packet
Post by: Mobius on April 20, 2022, 12:32:30 PM

The relation packet was not meant to be sent to a GM.
Read the warning.

If you do not want to get information about what is going on...

Code: [Select]

Index: java/org/l2jmobius/gameserver/network/serverpackets/RelationChanged.java
===================================================================
--- java/org/l2jmobius/gameserver/network/serverpackets/RelationChanged.java (revision 10070)
+++ java/org/l2jmobius/gameserver/network/serverpackets/RelationChanged.java (working copy)
@@ -77,7 +77,7 @@
  {
  if (activeChar.isInvisible())
  {
- throw new IllegalArgumentException("Cannot add insivisble character to multi relation packet");
+ return;
  }
  final Relation r = new Relation();
  r._objId = activeChar.getObjectId();


Title: Re: Multi relation packet
Post by: kinghanker on April 23, 2022, 01:03:53 AM

Code: [Select]

Index: java/org/l2jmobius/gameserver/network/serverpackets/RelationChanged.java
===================================================================
--- java/org/l2jmobius/gameserver/network/serverpackets/RelationChanged.java (revision 10070)
+++ java/org/l2jmobius/gameserver/network/serverpackets/RelationChanged.java (working copy)
@@ -78,7 +78,7 @@
  {
- if (activeChar.isInvisible())
+ if (activeChar.isInvisible() && !activeChar.isGM())
  {
throw new IllegalArgumentException("Cannot add insivisble character to multi relation packet");
return;
  }


Title: Re: Multi relation packet
Post by: Mobius on April 25, 2022, 01:03:12 PM

Fixed with https://bitbucket.org/MobiusDev/l2j_mobius/commits/00f43ba34dea10f5f2957dc83d9923c64d6e34fe