L2JMobius

Free Users => Shares/Contributions => Committed User Contributions => Topic started by: Helionar on July 07, 2020, 12:16:51 PM

Title: Wrong prev. quest name on Quest "Into The Large Cavern"
Post by: Helionar on July 07, 2020, 12:16:51 PM

Hi! As the topic subject, its pretty self-explanatory.

Diff:

Code: [Select]

diff --git a/dist/game/data/scripts/quests/Q00179_IntoTheLargeCavern/Q00179_IntoTheLargeCavern.java b/dist/game/data/scripts/quests/Q00179_IntoTheLargeCavern/Q00179_IntoTheLargeCavern.java
index 203adc8a36b4b70aa23bc9d0f0f917c215ad5163..672ad48cac815befd7689c8e2a0cda843ee48f0f 100644
--- a/dist/game/data/scripts/quests/Q00179_IntoTheLargeCavern/Q00179_IntoTheLargeCavern.java
+++ b/dist/game/data/scripts/quests/Q00179_IntoTheLargeCavern/Q00179_IntoTheLargeCavern.java
@@ -23,6 +23,8 @@ import org.l2jmobius.gameserver.model.quest.Quest;
 import org.l2jmobius.gameserver.model.quest.QuestState;
 import org.l2jmobius.gameserver.model.quest.State;
 
+import quests.Q00178_IconicTrinity.Q00178_IconicTrinity;
+
 /**
  * Into the Large Cavern (179)
  * @author Gnacik
@@ -33,6 +35,9 @@ public class Q00179_IntoTheLargeCavern extends Quest
  // NPCs
  private static final int KEKROPUS = 32138;
  private static final int MENACING_MACHINE = 32258;
+ // Misc
+ private static final int MIN_LEVEL = 17;
+ private static final int MAX_LEVEL = 21;
 
  public Q00179_IntoTheLargeCavern()
  {
@@ -94,9 +99,9 @@ public class Q00179_IntoTheLargeCavern extends Quest
  }
  else
  {
- final QuestState prev = player.getQuestState("178_IconicTrinity");
+ final QuestState prev = player.getQuestState(Q00178_IconicTrinity.class.getSimpleName());
  final int level = player.getLevel();
- if ((prev != null) && prev.isCompleted() && (level >= 17) && (level <= 21) && (player.getClassId().level() == 0))
+ if ((prev != null) && prev.isCompleted() && (level >= MIN_LEVEL) && (level <= MAX_LEVEL) && (player.getClassId().level() == 0))
  {
  htmltext = "32138-01.htm";
  }

PD: I have also moved que lvl requirements into constants, you can skip that!

Cheers!

Title: Re: Wrong prev. quest name on Quest "Into The Large Cavern"
Post by: Mobius on July 08, 2020, 07:00:06 AM

Moved to contributions section.

Title: Re: Wrong prev. quest name on Quest "Into The Large Cavern"
Post by: Mobius on July 08, 2020, 12:31:35 PM

Committed with https://bitbucket.org/MobiusDev/l2j_mobius/commits/ca481edb2d123ceee3c173f1f7cf9e2881d98232
Thanks :D