C6 Q343_UnderTheShadowOfTheIvoryTower

[Strelook66]

Hi guys,

So I've been testing the quests out and I found a bug in the quest name Under The Shadow of the Ivory Tower.

What works:

1. Start the quest/quit the quest
2. Can gather the required ores from the mobs
3. Can play rock paper scissors with Marsha and the coin toss with Trumpin. (rewards work)

Bug:
I cannot get the reward from Cema. When I go back to her to turn in the orbs, I keep getting the "start" quest part over and over again, and I can accept the quest indefinitely (with quest start sound), but no rewards. I get no errors or anything.

[Mobius]

Could be something near this.

Code: [Select]

Index: dist/game/data/scripts/quests/Q343_UnderTheShadowOfTheIvoryTower/Q343_UnderTheShadowOfTheIvoryTower.java
===================================================================
--- dist/game/data/scripts/quests/Q343_UnderTheShadowOfTheIvoryTower/Q343_UnderTheShadowOfTheIvoryTower.java (revision 7374)
+++ dist/game/data/scripts/quests/Q343_UnderTheShadowOfTheIvoryTower/Q343_UnderTheShadowOfTheIvoryTower.java (working copy)
@@ -372,7 +372,7 @@
  {
  case 30834:
  {
- if (id != 2)
+ if (id != State.STARTED)
  {
  for (int i : ALLOWED_CLASSES)
  {


[Mobius]

Full quest cleanup.

Code: [Select]

/*
 * This file is part of the L2J Mobius project.
 *
 * This program is free software: you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation, either version 3 of the License, or
 * (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
 * General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License
 * along with this program. If not, see <http://www.gnu.org/licenses/>.
 */
package quests.Q343_UnderTheShadowOfTheIvoryTower;

import org.l2jmobius.commons.util.Rnd;
import org.l2jmobius.gameserver.model.actor.instance.NpcInstance;
import org.l2jmobius.gameserver.model.actor.instance.PlayerInstance;
import org.l2jmobius.gameserver.model.quest.Quest;
import org.l2jmobius.gameserver.model.quest.QuestState;
import org.l2jmobius.gameserver.model.quest.State;

/**
 * Adapted from FirstTeam Interlude
 */
public class Q343_UnderTheShadowOfTheIvoryTower extends Quest
{
// NPCs
private static final int CEMA = 30834;
private static final int ICARUS = 30835;
private static final int MARSHA = 30934;
private static final int TRUMPIN = 30935;
private static final int[] MONSTERS = new int[]
{
20563,
20564,
20565,
20566
};
// Items
private static final int ORB = 4364;
private static final int ECTOPLASM = 4365;
// Misc
private static final int CHANCE = 50;
private static final int[] ALLOWED_CLASSES =
{
11,
12,
13,
14,
26,
27,
28,
39,
40,
41
};

public Q343_UnderTheShadowOfTheIvoryTower()
{
super(343, "Under the Shadow of the Ivory Tower");
addStartNpc(CEMA);
addTalkId(CEMA, ICARUS, MARSHA, TRUMPIN);
addKillId(MONSTERS);
registerQuestItems(ORB);
}

@Override
public String onAdvEvent(String event, NpcInstance npc, PlayerInstance player)
{
String htmltext = event;
final QuestState st = player.getQuestState(getName());
if (st == null)
{
return htmltext;
}

final int random1 = Rnd.get(3);
final int random2 = Rnd.get(2);
final int orbs = st.getQuestItemsCount(ORB);
switch (event)
{
case "30834-03.htm":
{
st.setState(State.STARTED);
st.set("cond", "1");
st.playSound("ItemSound.quest_accept");
break;
}
case "30834-08.htm":
{
if (orbs > 0)
{
st.giveItems(57, orbs * 120);
st.takeItems(ORB, -1);
}
else
{
htmltext = "30834-08.htm";
}
break;
}
case "30834-09.htm":
{
st.playSound("ItemSound.quest_finish");
st.exitQuest(true);
break;
}
case "30934-02.htm":
case "30934-03.htm":
{
if (orbs < 10)
{
htmltext = "noorbs.htm";
}
else if ("30934-03.htm".equals(event))
{
if (orbs >= 10)
{
st.takeItems(ORB, 10);
st.set("playing", "1");
}
else
{
htmltext = "noorbs.htm";
}
}
break;
}
case "30934-04.htm":
{
if (st.getInt("playing") > 0)
{
switch (random1)
{
case 0:
{
htmltext = "30934-05.htm";
st.giveItems(ORB, 10);
break;
}
case 1:
{
htmltext = "30934-06.htm";
break;
}
default:
{
htmltext = "30934-04.htm";
st.giveItems(ORB, 20);
break;
}
}
st.unset("playing");
}
else
{
htmltext = "Player is cheating";
st.takeItems(ORB, -1);
st.exitQuest(true);
}
break;
}
case "30934-05.htm":
{
if (st.getInt("playing") > 0)
{
switch (random1)
{
case 0:
{
htmltext = "30934-04.htm";
st.giveItems(ORB, 20);
break;
}
case 1:
{
htmltext = "30934-05.htm";
st.giveItems(ORB, 10);
break;
}
default:
{
htmltext = "30934-06.htm";
break;
}
}
st.unset("playing");
}
else
{
htmltext = "Player is cheating";
st.takeItems(ORB, -1);
st.exitQuest(true);
}
break;
}
case "30934-06.htm":
{
if (st.getInt("playing") > 0)
{
switch (random1)
{
case 0:
{
htmltext = "30934-04.htm";
st.giveItems(ORB, 20);
break;
}
case 1:
{
htmltext = "30934-06.htm";
break;
}
default:
{
htmltext = "30934-05.htm";
st.giveItems(ORB, 10);
break;
}
}
st.unset("playing");
}
else
{
htmltext = "Player is cheating";
st.takeItems(ORB, -1);
st.exitQuest(true);
}
break;
}
case "30935-02.htm":
case "30935-03.htm":
{
st.unset("toss");
if (orbs < 10)
{
htmltext = "noorbs.htm";
}
break;
}
case "30935-05.htm":
{
if (orbs >= 10)
{
if (random2 == 0)
{
final int toss = st.getInt("toss");
if (toss == 4)
{
st.unset("toss");
st.giveItems(ORB, 150);
htmltext = "30935-07.htm";
}
else
{
st.set("toss", String.valueOf(toss + 1));
htmltext = "30935-04.htm";
}
}
else
{
st.unset("toss");
st.takeItems(ORB, 10);
}
}
else
{
htmltext = "noorbs.htm";
}
break;
}
case "30935-06.htm":
{
if (orbs >= 10)
{
final int toss = st.getInt("toss");
st.unset("toss");
switch (toss)
{
case 1:
{
st.giveItems(ORB, 10);
break;
}
case 2:
{
st.giveItems(ORB, 30);
break;
}
case 3:
{
st.giveItems(ORB, 70);
break;
}
case 4:
{
st.giveItems(ORB, 150);
break;
}
}
}
else
{
htmltext = "noorbs.htm";
}
break;
}
case "30835-02.htm":
{
if (st.getQuestItemsCount(ECTOPLASM) > 0)
{
st.takeItems(ECTOPLASM, 1);
final int random3 = Rnd.get(1000);
if (random3 <= 119)
{
st.giveItems(955, 1);
}
else if (random3 <= 169)
{
st.giveItems(951, 1);
}
else if (random3 <= 329)
{
st.giveItems(2511, (Rnd.get(200) + 401));
}
else if (random3 <= 559)
{
st.giveItems(2510, (Rnd.get(200) + 401));
}
else if (random3 <= 561)
{
st.giveItems(316, 1);
}
else if (random3 <= 578)
{
st.giveItems(630, 1);
}
else if (random3 <= 579)
{
st.giveItems(188, 1);
}
else if (random3 <= 581)
{
st.giveItems(885, 1);
}
else if (random3 <= 582)
{
st.giveItems(103, 1);
}
else if (random3 <= 584)
{
st.giveItems(917, 1);
}
else
{
st.giveItems(736, 1);
}
}
else
{
htmltext = "30835-03.htm";
}
break;
}
}
return htmltext;
}

@Override
public String onTalk(NpcInstance npc, PlayerInstance player)
{
final QuestState st = player.getQuestState(getName());
String htmltext = getNoQuestMsg();
if (st == null)
{
return htmltext;
}

switch (npc.getNpcId())
{
case CEMA:
{
if (!st.isStarted())
{
for (int classId : ALLOWED_CLASSES)
{
if ((st.getPlayer().getClassId().getId() == classId) && (st.getPlayer().getLevel() >= 40))
{
htmltext = "30834-01.htm";
}
}
if (!"30834-01.htm".equals(htmltext))
{
htmltext = "30834-07.htm";
st.exitQuest(true);
}
}
else if (st.getQuestItemsCount(ORB) > 0)
{
htmltext = "30834-06.htm";
}
else
{
htmltext = "30834-05.htm";
}
break;
}
case ICARUS:
{
htmltext = "30835-01.htm";
break;
}
case MARSHA:
{
htmltext = "30934-01.htm";
break;
}
case TRUMPIN:
{
htmltext = "30935-01.htm";
break;
}
}
return htmltext;
}

@Override
public String onKill(NpcInstance npc, PlayerInstance player, boolean isPet)
{
final QuestState st = checkPlayerState(player, npc, State.STARTED);
if (st == null)
{
return null;
}

if (Rnd.get(100) < CHANCE)
{
st.giveItems(ORB, 1);
st.playSound("ItemSound.quest_itemget");
}

return null;
}
}

[Strelook66]

Yup, that did the trick. Thanks!

[Mobius]

Fixed with https://bitbucket.org/MobiusDev/l2j_mobius/commits/d8199fdc24373dd3cad9787604d59e04e1f4e03a