L2JMobius

Free Users => Shares/Contributions => Committed User Contributions => Topic started by: gruccia on February 17, 2019, 01:44:10 PM

Title: Party Cake small FIX
Post by: gruccia on February 17, 2019, 01:44:10 PM

Partial FIX Party Cake


in stats/item/21800-21899.xml

Code: [Select]

<item id="21881" type="EtcItem" name="Party Cake">
<!-- Dimensional item. Summons a party cake that maintains vitality for 20 minutes. It'll be effective only when summoned away at a certain distance from the town. Cannot be exchanged or dropped. Can be shared between characters within an account through the Dimensional Merchant. Can be stored in a private warehouse. -->
<set name="icon" val="BranchSys.icon.br_birthday_cake_i00" />
<set name="default_action" val="SKILL_REDUCE" />
<set name="etcitem_type" val="POTION" />
<set name="immediate_effect" val="true" />
<set name="material" val="PAPER" />
<set name="price" val="1" />
<set name="is_stackable" val="true" />
<set name="is_tradable" val="false" />
<set name="is_dropable" val="false" />
<set name="is_oly_restricted" val="true" />
<set name="handler" val="ItemSkills" />
<set name="item_skill" val="22303-1;22301-1" />
</item>
in stats/skill/22300-22399.xml

Code: [Select]

<skill id="22301" levels="1" name="Party Cake">
<set name="targetType" val="PARTY" />
<set name="affectRange" val="500" />
<set name="castRange" val="500" />
<set name="abnormalTime" val="1200" />
<set name="irreplaceableBuff" val="1"/>
<set name="icon" val="br_birthday_cake_i00" />
<set name="isMagic" val="2" /> <!-- Static Skill -->
<set name="magicLvl" val="1" />
<set name="operateType" val="A2" />
<for>
<effect name="Buff">
<mul stat="vitalityConsumeRate" val="0" />
</effect>
</for>
</skill>
and

Code: [Select]

<skill id="22303" levels="1" name="Party Cake">
<!-- Party Cake's Vitality effect. Maintains Vitality for 20 minutes. -->
<set name="targetType" val="SELF" />
<set name="abnormalTime" val="1200" />
<set name="isMagic" val="2" /> <!-- Static Skill -->
<set name="magicLvl" val="1" />
<set name="operateType" val="A1" />
<for>
<effect name="SummonNpc">
<param npcId="147" npcCount="1" despawnDelay="1200000" />
</effect>
</for>
</skill>
but remaing two small bug one is description in buff icon (https://i.imgur.com/VQ3XWa2.jpg) and one is the position on the ground of npc (https://i.imgur.com/IJXRLXp.jpg) btw buff work well

Title: Re: Party Cake small FIX
Post by: Mobius on February 17, 2019, 02:02:07 PM

Description is on client side.
Try to change NPC XML collition values.

Title: Re: Party Cake small FIX
Post by: gruccia on February 17, 2019, 04:23:01 PM

ok...so i have fix icon description by invert skill like this

Code: [Select]

<skill id="22301" levels="1" name="Party Cake">
<!-- Party Cake's Vitality effect. Maintains Vitality for 20 minutes. -->
<set name="targetType" val="SELF" />
<set name="abnormalTime" val="1200" />
<set name="isMagic" val="2" /> <!-- Static Skill -->
<set name="magicLvl" val="1" />
<set name="operateType" val="A1" />
<for>
<effect name="SummonNpc">
<param npcId="147" npcCount="1" despawnDelay="1200000" />
</effect>
</for>
</skill>

Code: [Select]

<skill id="22303" levels="1" name="Party Cake">
<!-- Party Cake's Vitality effect. Maintains Vitality for 20 minutes. -->
<set name="targetType" val="PARTY" />
<set name="affectRange" val="500" />
<set name="castRange" val="500" />
<set name="abnormalTime" val="1200" />
<set name="irreplaceableBuff" val="1"/>
<set name="icon" val="br_birthday_cake_i00" />
<set name="isMagic" val="2" /> <!-- Static Skill -->
<set name="magicLvl" val="1" />
<set name="operateType" val="A2" />
<for>
<effect name="Buff">
<mul stat="vitalityConsumeRate" val="0" />
</effect>
</for>
</skill>

but for position i have try change collision on npc id147

Code: [Select]

<collision>
<radius normal="0.01" />
<height normal="0.00" />
</collision>
but we can not go less than 0 so i dont think this can be by xml but need fix on client side or there is nother way that i dont know yet

Title: Re: Party Cake small FIX
Post by: Mobius on February 17, 2019, 07:20:01 PM

<set name="irreplaceableBuff" val="1"/> ?

Title: Re: Party Cake small FIX
Post by: gruccia on February 17, 2019, 08:29:53 PM

if I'm not wrong it is for not cancellable buff

Title: Re: Party Cake small FIX
Post by: Mobius on February 17, 2019, 09:36:43 PM

Problem is that this parameter does not exist. :P
Have you tried it without it?

Title: Re: Party Cake small FIX
Post by: gruccia on February 18, 2019, 11:12:34 AM

this parameter was implent in 2018 on L2j datapack i was think it work also here...but honestly i have not try if it work...anyway i heve notice now it was wrong because need true or false...sorry :P my fault...

Title: Re: Party Cake small FIX
Post by: Mobius on February 18, 2019, 01:16:59 PM

Great change, as always, L2jServer masters of rename.
https://bitbucket.org/l2jserver/l2j_server/commits/de65e11a7ff30423637f25b80ebd941f24c7dc06

Used
<set name="canBeDispeled" val="false" />

Committed with revision 4831.