L2JMobius

Free Users => Shares/Contributions => Topic started by: bestover72 on June 02, 2021, 12:05:30 AM

Title: Corrections in many skills
Post by: bestover72 on June 02, 2021, 12:05:30 AM
Hello Friends,
I hope all have a good day.

These corrections were a lot of work to discover, because they only manifest when the server is live on a vps (There is a bigger ping), because on localhost they do not manifest themselves.

Problem explanation: All dash, rush skills when you use on online server, the character returns to the initial cast location.

The problem is <effect name = "EnemyCharge" /> which derives public class EnemyCharge extends AbstractEffect
which is in the /game/data/scripts/handlers/effecthandlers/EnemyCharge.java file.

Need put on pastebin, because this mensage have max length 2000 characters

Skill correction: https://pastebin.com/bZwW0EBX (https://pastebin.com/bZwW0EBX)

Theres the path of files to correct:

I discovered another bug in another skill, but this time is not a rush/dash skill, is NPC Cancel Magic skill with id=4094

Problem explanation: All mobs that use this skill, the skill has a 100% chance and cancels all buffs. The correct thing is to have a 25% chance and cancel between 1 to 5 buffs

There the path of file to correct:

Skill correction:

How is the skill 4094 now in repository:

Code: [Select]
skill id="4094" levels="12" name="NPC Cancel Magic">
<table name="#magicLevel">10 20 30 40 50 60 70 75 80 85 90 95</table>
<table name="#mpConsume">10 16 21 28 36 44 52 55 58 60 61 62</table>
<table name="#mpInitialConsume">3 4 6 7 9 11 13 14 15 15 16 16</table>
<set name="affectScope" val="SINGLE" />
<set name="castRange" val="600" />
<set name="effectPoint" val="-100" />
<set name="effectRange" val="1100" />
<set name="hitTime" val="6000" />
<set name="isMagic" val="1" />  Magic Skill
<set name="magicLevel" val="#magicLevel" />
<set name="mpConsume" val="#mpConsume" />
<set name="mpInitialConsume" val="#mpInitialConsume" />
<set name="operateType" val="A1" />
<set name="rideState" val="NONE;STRIDER;WYVERN;WOLF" />
<set name="targetType" val="ONE" />
<for>
<effect name="DispelAll" />
</for>
</skill>
As it should be (4094):
Code: [Select]
<skill id="4094" levels="12" name="NPC Cancel Magic">
    <!-- Confirmed CT2.5 -->
    <table name="#magicLvl"> 10 20 30 40 50 60 70 75 80 85 90 95 </table>
    <table name="#mpConsume"> 10 16 21 28 36 44 52 55 58 60 61 62 </table>
    <table name="#mpInitialConsume"> 3 4 6 7 9 11 13 14 15 15 16 16 </table>
    <set name="castRange" val="600" />
    <set name="effectPoint" val="-100" />
    <set name="effectRange" val="1100" />
    <set name="hitTime" val="6000" />
    <set name="isMagic" val="1" /> <!-- Magic Skill -->
    <set name="magicLvl" val="#magicLvl" />
    <set name="mpConsume" val="#mpConsume" />
    <set name="mpInitialConsume" val="#mpInitialConsume" />
    <set name="operateType" val="A1" />
    <set name="targetType" val="ONE" />
    <for>
        <effect name="DispelByCategory" noicon="1" val="0">
            <param slot="buff" rate="25" max="5" />
        </effect>
    </for>
</skill>
Title: Re: Corrections in many skills
Post by: Mobius on June 02, 2021, 12:15:05 PM
EnemyCharge works fine for me.
Removing it will break all those skills.

Also there is no parameter rideState.
Do you use latest L2jMobius files from the download link?
Title: Re: Corrections in many skills
Post by: bestover72 on June 02, 2021, 03:48:03 PM
Yes i use the last update from free version.
If i uncomment the enemycharge line my players can't use the skill properly.
Like i said, this bug is hard to test, because in localhost server the bug dont manifest. Im gonna test on your live server and send you a video.

If i commented EnemyCharge line, the skill work like a charm.
Title: Re: Corrections in many skills
Post by: Mobius on June 02, 2021, 09:35:27 PM
By removing EnemyCharge the player wont move to proper location.
Title: Re: Corrections in many skills
Post by: galonforever on January 04, 2022, 09:54:51 PM

I have the free version in a vps and the character goes back to the beginning sometimes.
Any solution?