C6 //delete command does not save to database

[G-hamsteR]

Using the //delete command for normal spawnlist and normal npc, doesn't delete them from spawnlist. They are only deleted from the game until the next restart.

If it's used on custom npcs with custom_spawnlist, they are deleted.

[G-hamsteR]

The problem is at SpawnTable.java

Line 320:

Code: [Select]

final PreparedStatement statement = con.prepareStatement("DELETE FROM " + (Config.SAVE_GMSPAWN_ON_CUSTOM ? "custom_spawnlist" : "spawnlist") + " WHERE id=?");
I have SAVE_GMSPAWN_ON_CUSTOM = True in my configs because I want new spawns to be inserted into the custom_spawnlist table. However, I still want to be able to delete all NPC, custom or not.

Maybe this fixes the problem:
Changing this:

Code: [Select]

try (Connection con = DatabaseFactory.getConnection())
{
final PreparedStatement statement = con.prepareStatement("DELETE FROM " + (Config.SAVE_GMSPAWN_ON_CUSTOM ? "custom_spawnlist" : "spawnlist") + " WHERE id=?");
statement.setInt(1, spawn.getId());
statement.execute();
statement.close();
}
To this:

Code: [Select]

try (Connection con = DatabaseFactory.getConnection())
{
PreparedStatement statement;
statement = con.prepareStatement("DELETE FROM custom_spawnlist WHERE id=?");
statement.setInt(1, spawn.getId());
statement.execute();
statement.close();

statement = con.prepareStatement("DELETE FROM spawnlist WHERE id=?");
statement.setInt(1, spawn.getId());
statement.execute();
statement.close();
}

[Mobius]

Probably should do the trick.

[Mobius]

Fixed with https://bitbucket.org/MobiusDev/l2j_mobius/commits/b9c27bb197d59c01c368f2925b13f21c122909ae
Thanks