L2JMobius

Free Users => Shares/Contributions => Archived User Contributions => Topic started by: NIIcK on March 08, 2019, 12:29:09 PM

Title: Possible fixes for lucky, plunder and la vie en rose
Post by: NIIcK on March 08, 2019, 12:29:09 PM

Tested on Grand Crusade!

- implementation for Lucky clover effect based on the character luck
- implementation for plunder skills and added the 105-110
- implementation for la vie en rose section for merchant of mammon

Please confirm/infirm.

Diff file: -removed-

Title: Re: Possible fixes for lucky, plunder and la vie en rose
Post by: Sdw- on March 08, 2019, 08:37:08 PM

Infirming

Title: Re: Possible fixes for lucky, plunder and la vie en rose
Post by: Mobius on March 10, 2019, 11:58:48 AM

Got some idea on why you made this.
But patch is unusable.

Patch code style format differs project style, a lot. Making diff hard to read / see what has changed.
Checkout the project as described in my guide, then make a patch only for what you want to share.
Patch removed.

Also separate shares should have separate posts.

Title: Re: Possible fixes for lucky, plunder and la vie en rose
Post by: Mobius on March 10, 2019, 02:37:34 PM

I made some improvements on my own for the current plunder skill with revision 4977.
Skill level changes committed with revision 4978.